Repository navigation
upcoming, change: [M3-7524] - Add child_account OAuth scope to Create and View PAT drawers - #9992
Merged
mjac0bs merged 13 commits intoDec 20, 2023
Conversation
mjac0bs
force-pushed
the
M3-7411-add-new-oauth-scope-to-new-endpoints
branch
from
December 13, 2023 23:38
70f1a49 to
adb0d02
Compare
added 3 commits
December 18, 2023 14:47
mjac0bs
commented
Dec 18, 2023
mjac0bs
marked this pull request as ready for review
December 18, 2023 23:05
mjac0bs
requested review from
coliu-akamai,
cpathipa and
tyler-akamai
and removed request for
a team
December 18, 2023 23:05
jaalah-akamai
approved these changes
Dec 19, 2023
jaalah-akamai
left a comment
Contributor
There was a problem hiding this comment.
Approving pending some revisions - I was able to test everything as listed and the tests passed ✅
Contributor
|
Verified:
LGTM 🚀 |
|
Coverage Report: ✅ |
tyler-akamai
approved these changes
Dec 19, 2023
This was referenced Jan 4, 2024
7 of 12 tasks
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
New Scope:
Introduce a new OAuth scope named "child_account" for all users, but visible only to "Parent" accounts. As per API spec: its purpose is to allow Parent Account Users with the
child_account_accessgrant to specify a Token with less permission than their User, i.e. a Token that is unable to list and/or create Tokens for the Child Account(s).Token Configuration:
Default all scopes to
nonefor users. Users should enable scopes as needed, contrary to having the initial state set toread_write.Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
yarn dev.Verification steps
(How to verify changes)
serverHandler.tsand edit the following request to change the user_type tonull,child, orproxy:As an Author I have considered 🤔
Check all that apply