Repository navigation
chore: refine pii review instructions - #2505
Merged
Merged
Conversation
|
chenghao-mou
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports livekit/agents#7267 to refine PII review guidance and reduce false positives around ordinary diagnostics, exception paths, and explicitly redacted telemetry attributes.
Changes Made
Source diff coverage
REVIEW.md: adapted to targetREVIEW.md. Ported all policy changes while translating Python-specific references to JavaScript/TypeScript equivalents:.pytelemetry paths to.ts; Python exception logging, formatting, chaining, and background task behavior to structured JS errors,String(error), stack traces,cause, and unhandled promise rejections; aiohttp andClientErrorexamples to WebSocket and Node network errors; and Python logging examples to Pino-style TypeScript.Pre-Review Checklist
pnpm buildTesting
pnpm buildpnpm lint(passes with existing warnings)pnpm exec prettier --check REVIEW.mdpnpm test: full suite rerun after build; 3,448 passed and 35 skipped, with 6 unrelated failures. Failures require a missingCEREBRAS_API_KEY, external OpenAI/evaluator behavior, or valid LFS-backed Silero model/audio assets (silero_vad.onnxand test WAV content). No package code changed and source PR #7267 contains no tests.Additional Notes
cue-cliruntime validation is not applicable.Ported from livekit/agents#7267
Original PR description
Devin flags ordinary diagnostics and hypothetical exception leaks. Require a concrete sensitive value and reachable, unprotected output while retaining content-redaction requirements.
Adopts @GregHolmes's exception-path diagnosis (#7206) and @davidzhao's metadata distinction (#7128); excludes unused-key findings withdrawn in #7104.
Addresses AGT-3507.
Validation:
git diff --checkand lint passed.make checkstopped on existing formatting inrecorder_io.py.Initial prompt and agent context
Model: GPT-6