fix: defer OnStreamRecv so recv error and bytes are observed correctly - #116
Open
steve-weiland wants to merge 1 commit into
Open
fix: defer OnStreamRecv so recv error and bytes are observed correctly#116steve-weiland wants to merge 1 commit into
steve-weiland wants to merge 1 commit into
Conversation
Author
|
Bumping this gently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
streamMetricsInterceptor.Recvrecords its metric before calling the downstream handler, soerris always nil andproto.Size(msg)measures an empty message, every stream-recv metric reportserr == nilandbytes == 0.Sendalready defers correctly;Recvdoesn't.Fix
Defer
OnStreamRecvso it runs after the handler returns, mirroringSend. AddsTestStreamMetricsRecvObservedAfterHandler, which fails on the old ordering and passes with the fix.No behavioral change beyond metric accuracy.