clamp connection timeout and fixed the comment - #748
Merged
xianshijing-lk merged 2 commits intoOct 19, 2025
Merged
Conversation
ladvoc
approved these changes
Oct 16, 2025
ladvoc
left a comment
ladvoc
left a comment
Contributor
There was a problem hiding this comment.
Change looks good! Two notes:
- The build failure on Android is not related to this PR—I am investigating the cause
- To make the format check pass, run
cargo fmtand commit the changes
xianshijing-lk
force-pushed
the
sxian/CLT-2132/fix_rpc_responseTimeout_comment_and_clamp_the_timeout
branch
from
October 19, 2025 03:11
87e9200 to
0563cda
Compare
xianshijing-lk
deleted the
sxian/CLT-2132/fix_rpc_responseTimeout_comment_and_clamp_the_timeout
branch
October 19, 2025 03:58
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the problem is that the performRpc is a public function, and we never sanity check if users provide values larger than the connection_timeout, which might cause unexpected behavior.
This PR fixes the comment and also clamp the connection response timeout if needed.