Conversation
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 4, 2026 16:04
c397f06 to
4f4ffd0
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 4, 2026 22:57
4f4ffd0 to
576a193
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
3 times, most recently
from
September 14, 2026 22:27
ad96dc6 to
564afc2
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 22, 2026 16:46
564afc2 to
254d407
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 22, 2026 20:53
254d407 to
a8f7eda
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 22, 2026 22:20
a8f7eda to
05fc6e8
Compare
ladvoc
force-pushed
the
ladvoc/data-track-e2e-test
branch
from
September 22, 2026 23:41
05fc6e8 to
ae2a837
Compare
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Devin Review: 3 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
boks1971
approved these changes
Sep 29, 2026
| rooms = append(rooms, testRoom{room: room, published: published}) | ||
| } | ||
|
|
||
| // Wait for participant visibility across all room connections. When using a local SFU, this |
Contributor
There was a problem hiding this comment.
why does local SFU take longer?
| require.Len(t, frame.Payload, tc.payloadLen) | ||
| require.Equal(t, bytes.Repeat([]byte{payloadValue}, tc.payloadLen), frame.Payload) | ||
| require.Nil(t, frame.UserTimestamp) | ||
| require.True(t, remoteTrack.IsPublished()) |
Contributor
There was a problem hiding this comment.
Not sure what this checks, but there one call before the Subscribe too. Is this checking something different?
| initialSID := track.Info().SID | ||
|
|
||
| pubRoom.room.Simulate(tc.scenario) | ||
| require.True(t, track.IsPublished(), "Should still be reported as published") |
Contributor
There was a problem hiding this comment.
all lower case, may be in other places too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes BOT-541