Fix sockaddr - #168
Merged
2 commits merged intoJun 18, 2016
Merged
Conversation
added 2 commits
June 18, 2016 22:24
__kernel_sockaddr_storage is just the kernel internal storage space for sockaddr. The userspace visible sockaddr needs to be 16 bytes, as that is what used in several other structures visible to userpace APIs (e.g. struct arpreq). Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Even if run_netperf.sh uses #!/bin/bash it is invoked via sh which under Ubuntu may be dash. Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Author
|
@liuyuan10 I think I have a fix for the sockaddr issue. Can you please review and test your change on top of this PR? Thank yuo! |
Member
|
LGTM |
Member
|
LGTM too |
Merged
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is