Skip to content

Subclassing not properly defined #382

New issue
New issue
Closed
Closed
Subclassing not properly defined#382
Labels
Fixedenhancement

Description

@tomekkosinski
tomekkosinski
opened on Sep 24, 2022

if issubclass( Form, CustomForm ):
print('yeee')
else:
print('nope') # always here

It seems that tp_base of the inherited class is not set.

Activity

  1. pyscripter commented on Sep 30, 2022

    @pyscripter
    pyscripter
    on Sep 30, 2022
    Collaborator

    Indeed, tp_base is never set. Is it important?

    Could be fixed in a couple of ways.

    1. RegisterDelphiWrapper should try to find the nearest parent class registered and set tp_base accordingly
    2. Implement __subclasshook__ in TPyDelphiObject
  2. pyscripter
    added
    Priority-Medium
    on Sep 30, 2022
  3. pyscripter
    added
    enhancement
    on Nov 29, 2022
  4. pyscripter
    closed this as completedin a945a65on Dec 27, 2022
  5. pyscripter
    added
    Fixed
    and removed
    Priority-Medium
    on Dec 27, 2022

  6. pyscripter commented on Dec 27, 2022

    @pyscripter
    pyscripter
    on Dec 27, 2022
    Collaborator

    @cosina Could you please confirm it is now working as expected?

  7. pyscripter
    added a commit that references this issue on Dec 28, 2022

    Call to inherited removed from RegisterMethods and RegisterGetSets, f…

    45ca26c
  8. kevind7
    added a commit that references this issue on Jan 29, 2024

    Fix lmbelo#382

    a945a65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Fixedenhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions