Skip to content

sometimes it doesn't show the fiatsent message #595

Open

Description

@Catrya

Sometimes, when a buyer presses the /fiasent command, and after selecting the order, even though it goes to fiat-sent status, the bot does not show the buyer the message I_told_seller_you_sent_fiat, and it does not show the seller the message buyer_told_me_that_sent_fiat

other times, but much less frequently, the bot does not enter the wizard_add_invoice_init wizard

I don't know if it's a bot error or a message delivery error on Telegram's part, as there have been reports of message failures lately https://downdetector.su/telegram

Activity

  1. ToRyVand commented on Jun 9, 2026

    @ToRyVand
    Contributor

    Hey @Catrya — it's a bot-side bug, not just Telegram. In fiatSentMessages the three sendMessage calls are awaited in one try/catch, so if the first fails transiently the rest are skipped and the error is only logged — while the order is already saved as FIAT_SENT. Status changes, nobody gets notified.

    I'd like to take this: send each message independently and stop swallowing errors. I'll check the wizard_add_invoice_init path too — same pattern.

  2. Catrya commented on Jun 12, 2026

    @Catrya
    MemberAuthor

    Hi @ToRyVand great that you want to work on this issue. I can assign it to you once the PRs for your other assigned issues are merged. Please remind me in the future so I can do so

  3. ToRyVand commented on Aug 3, 2026

    @ToRyVand
    Contributor

    Hi @Catrya — reminding you as you kindly suggested 🙂 Some of my PRs have been landing: the Lightning v11 upgrade (#806) was just merged, #814 is approved, and #778/#847 are in review. Whenever you feel it's the right time, I'd be glad to take on this one — I've already prepared and validated a fix (independent per-recipient sends so a transient failure to one party no longer skips the others, plus role/tg_id logging), so I can open the PR as soon as you assign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions