Repository navigation
Conversation
This was referenced Oct 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
Link
ggml-vulkanprivately to the header-onlySPIRV-Headers::SPIRV-Headerstarget so headers found throughCMAKE_PREFIX_PATHalso reach the compiler. Import the already-discovered package in the parent scope before linking: GGML's imported target is scoped to its subdirectory.System-installed headers continue to work through the same package target. No runtime library is added, no global include path is changed, and Vulkan-disabled builds do not discover or depend on SPIRV-Headers. The GGML submodule remains unchanged.
Add an Ubuntu CI matrix for system headers, headers relocated to a custom prefix, and Vulkan disabled. The custom-prefix job verifies the header is absent from the compiler's default search path and checks the actual
ggml-vulkan.cppcompile command before building. No model weights or GPU are required.Local validation passed: reproduced the missing-header failure by removing only the propagated include from the Vulkan compile command; built the project with a custom-prefix package and inherited SPIRV include paths removed from the Nix environment; built the main library/executable with Vulkan and SPIRV package discovery disabled. Three fixture-independent tests and a 30-frame Vulkan generation smoke test passed.
Companion PR: localai-org/skin-tokens.cpp#6.
CI validation: all three Ubuntu jobs passed (system headers, custom-prefix headers, and Vulkan disabled).