Repository navigation
fix(quota): scope vision authoring to material CLI closeout - #6236
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent; gpt-6.1-sol; OpenAI; runtime_reported; xhigh.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Exact head: 8d37899ce5e199d5328dc6df48de8ee295a0a169.
动机
读取 quota CLI 结算说明的 Agent。同一已准入的进行中身份:base 带实质 authoring,head 不带;实质 CLI 和 MCP 保留该契约。真实 quota CLI 的进行中包不带实质 authoring;不可变模块比较确认其他字段全部相同。本 PR 只按已有 delivery boundary 投影 CLI 编写说明;不改 Vision 校验、Todo 生命周期、命令、回执或 debit,不修改模型判定与调用预算。quota CLI 的进行中 Turn 已被允许使用原 continuation 命令,却仍收到实质收尾的 Vision 文件编写例子。Agent 可能因此重建一个不同的收尾命令。本改动移除该分支不适用的说明,保留原命令与身份,属于 justified_increment;不将先前模型失败推断为已解决。真实模型完整 portfolio 与最终 release commit 资格尚未完成;这项修复不证明模型终态语义收尾能力。
改动思路
本 PR 只按已有 delivery boundary 投影 CLI 编写说明;不改 Vision 校验、Todo 生命周期、命令、回执或 debit,不修改模型判定与调用预算。复用原 TypeScript inFlight 分支即可修复说明的适用范围,无需新增状态、配置、解析器或 Python 决策源。Long-horizon 行为 preserved:验证、原回执、单次 debit 和 Todo 连续性不变;user_experience improved:CLI Agent 只收到当前分支适用的编写结构。CLI 进行中能力与 MCP complete_task 的实质完成是不同操作,后者必须继续保留 authoring。
具体改动
关键代码讲解
turnScopedCliSettlementPlan 使用原 inFlight bool,仅在 Todo 绑定且不是进行中时附带 visionAuthoringContract();后者是未改变的 schema/说明 owner。projectMcpInteraction 未改动,继续将该契约交给实质 complete_task。Python 测试通过真实 quota CLI 断言字段缺席,并继续验证原 Todo、写回、spend 与下轮连续性。TS 测试重命名为新边界,覆盖 material/in-flight/MCP;协议补充中英文行为说明。
依据 Vision Checkpoint,spec_revision 2510aeb7b89f25c84f244f4c3ceea4abdfde5caa:In-flight continuation implemented;Material closeout implemented;Release portfolio deferred。后者仍需发布来源的真实资格,不由这项说明修复代替。
对主干的风险
最强反例是误删实质完成的 Vision 编写能力。生产模块配对执行表明 material 全投影完全相同,in-flight 只移除 authoring,命令、义务、身份及 debit 不变;MCP 在两种 CLI admission 下都保留 authoring。原 checkpoint 的缺失、非法 outcome、其他 Todo 与 replay 反例继续覆盖。
123 项真实 CLI/Python 回归、164 项 TS 检查通过;风险验证 17 selected /4 direct 检查无失败、警告或 manual hold。Typecheck、Ruff、diff hygiene 与语义 advisory 通过。测试执行的 runtime/test 字节与该提交一致,未查询 PR CI。公开边界扫描通过,未改变 OS/数据库/权限 owner,也不证明所有真实模型能操作该协议。终态资格场景与完整 Vision 收尾的覆盖范围须继续明确记录。
我的整体评价
APPROVE,justified_increment。本 PR 只按已有 delivery boundary 投影 CLI 编写说明;不改 Vision 校验、Todo 生命周期、命令、回执或 debit,不修改模型判定与调用预算。复用原 TypeScript inFlight 分支即可修复说明的适用范围,无需新增状态、配置、解析器或 Python 决策源。Future-facing pass 复用了已存在的 typed boundary,删除不适用说明,未增加框架或 Python 决策源。实质 authoring、执行权限和义务仍归原 owner;停止、续跑和证据来源条款未缩写。真实模型完整 portfolio 与最终 release commit 资格尚未完成;这项修复不证明模型终态语义收尾能力。
English verdict: APPROVE at 8d37899ce5e199d5328dc6df48de8ee295a0a169. The existing typed boundary removes only material authoring from in-flight CLI guidance. Material CLI projection is equal and MCP completion retains authoring; commands, identity, validation, receipt and debit semantics are unchanged. 123 real CLI/Python and164 TypeScript tests pass, with17 selected/four direct risk checks and no manual holds. Real-model portfolio and final release-source qualification remain separate.
An admitted
in_flight_continuationTurn exposed the material-closeout Vision authoring schema beside a writeback command that does not require it. This can prompt an agent to reconstruct a different closeout instead of preserving its projected continuation command.The existing TypeScript settlement owner now publishes that schema only for material Todo closeout. Material CLI and MCP
complete_taskkeep the original authoring contract; command, identity, validation, receipt and debit semantics remain unchanged. This is a guidance repair, and it does not certify a real-model portfolio.Validation: 164 TypeScript tests pass across settlement plans, checkpoints, continuity and receipt readback; control-plane typecheck passes. Paired immutable module execution confirms material projection equality and that only the in-flight authoring field changes. 123 real-CLI/Python regressions pass, including original Todo continuity and strict checkpoint/replay cases. Final exact-head review records risk results separately. No PR CI is queried. Related future-facing pass reuses the existing typed boundary and owner; no new vocabulary, switch, helper or state is added.