Skip to content

🧹 Janitor: Refactor TestFetchAndParseRejectsNon2xx to use setupTestServer - #197

Draft
google-labs-jules[bot] wants to merge 1 commit into
masterfrom
janitor/refactor-test-server-setup-12468925295502054414
Draft

google-labs-jules[bot] wants to merge 1 commit into
masterfrom
janitor/refactor-test-server-setup-12468925295502054414

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Assumptions

  • The intent of setupTestServer is to standardize mock HTTP server creation in tests that override the global HTTP client.
  • Modifying setupTestServer to accept an HTTP status code is safe and necessary to reuse it across tests returning different responses (e.g. 200 OK vs 404 Not Found).
  • The earlier PR (🧹 Janitor: Refactor test server setup in index_test.go to remove duplication #194) missed TestFetchAndParseRejectsNon2xx because the helper did not support custom status codes at the time.

Alternatives Not Chosen

  • Leaving the duplicate code: Rejected because it violates the memory rule requiring all index_test.go client overrides to use setupTestServer.
  • Creating a separate helper for errors (e.g., setupTestServerError): Rejected because adding a status parameter to the existing helper is simpler and prevents further fragmentation of test setup logic.

How To Pivot

  • If a future test requires completely custom headers or a delayed response, the setupTestServer helper might need to be refactored again to accept an http.HandlerFunc directly rather than string body/status code.

Next Knobs

  1. Extend setupTestServer to accept custom headers: Allow tests to mock server behavior for rate limits or content types.
  2. Refactor URL parsing in tests: Create a helper to construct mock URLs cleanly instead of repeating url.Parse(srv.URL).
  3. Migrate other packages' tests (if any exist) to use standard mock handlers: Standardize the HTTP client test mocking across the entire codebase.

PR created automatically by Jules for task 12468925295502054414 started by @lucasew

@vercel

vercel Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
articleparser Error Error Jul 27, 2026 8:00am

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

This branch had an error being deployed

1 failed deployment
Preview — ea79c607 Deployed Jul 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants