Repository navigation
feat: HTML lang attribute - #53
Conversation
|
Hey @paulwer 👋 Thank you for all of your contributions. I'll merge this soon after updating the tests and will look at the rest of the pull requests afterwards. |
|
@lukin i guess the attribute should also be added within the test-files? should I add another commit including this? f.ex. in https://github.com/lukin/keywind/blob/master/html/login/error.html |
|
Hello Should we also think about RTL languages (Arabic, Hebrew, Persian...)? Currently I want to extend template.ftl and introduce |
|
@maxsivkov I suggest you to create an pr or issue for this topic seperatly <3 |
|
I apologize for my delayed response. From today, I will start a review of all these exciting changes. 🙂 I haven't had the chance to create the tests documentation yet, but here's a summary. When you run the |
|
very nice. thank you <3 |
Co-authored-by: Anthony Lukin <anthony@lukin.dev>
As within file:
https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources/theme/base/login/template.ftl
Keycloak sets the html default language tag to the current language, which can be usefull for screen readers or additional plugins.
keycloak/keycloak@4036324#diff-8f5ce48097e1dfc8ce6ebfc5b0c4f1a387d40cfe4abe8bde76da550e09574256