RT-166: characterize gate owner derivation and notify-bridge filtering

[m4ttheweric]

Summary

Characterization tests for RT-162 finding 4 (does a worker-opened gate raise a desktop notification to the human?) against today's code. Verdict: REFUTED. deriveOwner and the notify bridge are deliberately unchanged (C15); the verdict doc is referenced in the lane report.

• Pins deriveOwner(undefined, ...) and a presentation: "wait" gate with no runId both resolving to "human" today
• Pins the owner: "human" bridge rule delivering a human-owned gate and skipping a herd-owned one, regardless of subject
• Test-only diff, no fix code: these tests must pass before and after any later Task 2 change (which adds a third case, not a flip of these two)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Added coverage to verify that gate notifications are correctly delivered to human-owned gates while excluding herd-owned gates with the same subject when no run ID is available.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5faa5200-234b-47f2-ac50-55b81462944a

📥 Commits

Reviewing files that changed from the base of the PR and between 7a70c75 and 5f77b98.

📒 Files selected for processing (1)

• lib/daemon/__tests__/gate-owner-notify-trace.test.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

---

📝 Walkthrough

Walkthrough

The change adds tests for gate owner derivation and notification filtering. Gates without run IDs derive the "human" owner. A human-owned bridge rule delivers the human event and excludes a herd-owned event with the same subject.

Changes

Gate owner notification coverage

Layer / File(s)	Summary
Owner derivation and notification filtering lib/daemon/__tests__/gate-owner-notify-trace.test.ts	Adds a fake broadcast bus and tests that missing run IDs or wait presentations derive "human". The tests verify that an owner-"human" bridge rule excludes the herd-owned event.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5f77b

The added tests document the existing owner-derivation and notification-filtering behavior without changing production behavior. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the characterization tests for gate owner derivation and notify-bridge filtering. It matches the main changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rt-166

---

_{Comment @coderabbitai help to get the list of available commands.}