RT-151: wave-2 MCP tools (gate_ask, mr_comment_inline, mr_map) and gate_list cursor - #277
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Comment |
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…e retry doc Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…_list test fixture field name resolveRepoIdentity now refuses ambiguous repo labels instead of silently picking the first match, naming all colliding identities in the error. gate_ask's env-forwarding contract (sessionId/paneId from env, subject from input only, RT_GATE_SUBJECT never read) now has a real behavioral test instead of a shape-only placeholder. gate_list's cursor test fixture used "next" instead of the real wire field "cursor". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ng end and mr_comment_inline's GitLab-only scope, fix invalid test fixture presentation value Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…T set) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
m4ttheweric
added a commit
that referenced
this pull request
Sep 17, 2026
…te_list cursor (#277) * mcp: gate_ask tool (RT-151) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * mcp: mr_comment_inline tool with shared 30s write timeout; tighten the retry doc Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * mcp: mr_map tool (RT-154 re-parked: all open MRs) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * mcp: gate_list cursor + gate_answer rejection sentences (RT-155) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * mcp e2e: roster grows to 15 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * mcp: fix mr_map repo-label ambiguity, add gate_ask env test, fix gate_list test fixture field name resolveRepoIdentity now refuses ambiguous repo labels instead of silently picking the first match, naming all colliding identities in the error. gate_ask's env-forwarding contract (sessionId/paneId from env, subject from input only, RT_GATE_SUBJECT never read) now has a real behavioral test instead of a shape-only placeholder. gate_list's cursor test fixture used "next" instead of the real wire field "cursor". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * mcp tools: guard nested daemon-reply dereferences, doc gate_list paging end and mr_comment_inline's GitLab-only scope, fix invalid test fixture presentation value Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * mcp tools: add the real C13 case (no explicit subject, RT_GATE_SUBJECT set) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grows the MCP tool roster from 12 to 15 and adds cursor support to
gate_list.gate_asktool (RT-151): shared-presentation question over the daemon'sgate:askmr_comment_inlinetool: dedicated 30s client write timeout, tightened repair/retry languagemr_maptool (RT-154 re-parked): ships all-open-MR semantics;authors[me]filtering deferred to RT-154gate_listcursor plus tightenedgate_answerrejection sentences (RT-155)mr_maprepo-label ambiguity, adds agate_askenv test, fixes agate_listtest fixture field nameNote: touches
packages/rt-client/src/commands.ts(doc comment only, no shape change); rt-165 owns the 0.23.0 bump in that file, so this branch rebases over rt-165 once it lands.Review
CodeRabbit was rate-limited (org cap: 1 review/hour) with zero comments posted; the usual fallback model (fable) was also out of usage credits, so this PR's substitute adversarial review ran on Claude Opus 5. No blocking findings. Fixed: three unguarded nested daemon-reply dereferences,
gate_list's paging-end documentation,mr_comment_inline's missing GitLab-only note, an invalid test fixture value, and agate_asktest that didn't actually cover the RT_GATE_SUBJECT-shadow contract it claimed (added the real C13 case; verified it fails without the fix). Two findings are ticketed separately rather than fixed here: a repo-identity heal-pair dedupe gap inresolveRepoIdentity(dormant today), and MCP tools returning raw daemon error codes instead ofexplainErrorprose.🤖 Generated with Claude Code