rt-tray: a quit with no window on screen is a real quit - #283
Merged
Merged
Conversation
The window-close interception also caught quits that had no window to close, so scripts, the Dock, and Activity Monitor could not stop the app once the window was closed; only the tray menu could. The decision now folds in whether a window is on screen, as a pure core helper with checks. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
m4ttheweric
added a commit
that referenced
this pull request
Sep 17, 2026
The window-close interception also caught quits that had no window to close, so scripts, the Dock, and Activity Monitor could not stop the app once the window was closed; only the tray menu could. The decision now folds in whether a window is on screen, as a pure core helper with checks. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the dock-first tray work. The window-close quit interception also swallowed quits that had nothing to close: with the mattstack window closed, an AppleScript quit, the Dock's Quit, or Activity Monitor could not stop the app at all, leaving only the tray menu (I hit this installing a build and had to
pkill).QuitReason.shouldTerminatenow folds the whole decision into one pure helper: confirmed tray quit, session end, or a system reason terminates, and so does any quit arriving with no window on screen. Cmd-Q with the window open still just closes the window and keeps supervision alive.216 checks green (3 new).
🤖 Generated with Claude Code