rt-tray: add a Window menu so cmd-W closes the window - #286
Merged
Merged
Conversation
AppKit routes a key equivalent only when a menu item claims it, and the app's custom menu bar had no Close item, so cmd-W did nothing in the mattstack window. Adds Close (cmd-W) and Minimize (cmd-M); both go through performClose:/performMiniaturize: on the key window, so the close path stays the one the titlebar button already uses. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe main menu now includes a Window menu with Close ( ChangesWindow Menu Shortcuts
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The new Close and Minimize shortcuts are wired to supported key-window actions without an identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
m4ttheweric
added a commit
that referenced
this pull request
Sep 17, 2026
AppKit routes a key equivalent only when a menu item claims it, and the app's custom menu bar had no Close item, so cmd-W did nothing in the mattstack window. Adds Close (cmd-W) and Minimize (cmd-M); both go through performClose:/performMiniaturize: on the key window, so the close path stays the one the titlebar button already uses. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd-W did nothing in the mattstack window: AppKit only routes a key equivalent that a menu item claims, and this app builds its own menu bar (App + Edit) with no Close item.
Adds a Window menu with Close (cmd-W) and Minimize (cmd-M), both dispatched through
performClose:/performMiniaturize:so closing follows the same path as the titlebar button, including the activation-policy flip back to accessory.No File menu: this app has no documents, and Close lives under Window on macOS.
216 checks green.
🤖 Generated with Claude Code
Summary by CodeRabbit