fastbrowser.setup: skip survives the requested-host-absent wording

[m4ttheweric]

The v2.9.0 rehearsal (run 35233591900) dead-ended in the CI clean-room: fast-browser now says "Requested claude host was not detected" where it used to say "Detected hosts: none", so the honest-skip match in fastbrowser.setup degraded to the loud failure it was designed to degrade to, and Install stopped at fastbrowser.setup on a runner with no Claude host.

One-line fix: broaden NO_HOST_STDERR to match both spellings (Requested \S+ host was not detected). Test-first: new case with the 0.1.1 wording was RED, now GREEN; the interactive path stays loud and a non-host failure stays failed (existing cases untouched, 102/102 pass, tsc clean).

Release-blocking for v2.9.0: the rehearsal cannot pass without it.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved setup handling for alternate fast-browser messages indicating that the requested host was not detected.
  • Non-interactive setup now skips appropriately while preserving the existing no-host details.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dc8933b4-da69-4d7a-ac42-49fbb94ec949

📥 Commits

Reviewing files that changed from the base of the PR and between 27337d9 and cb8a7fc.

📒 Files selected for processing (2)

• lib/setup/__tests__/steps-c.test.ts
• lib/setup/steps/tools.ts

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

---

📝 Walkthrough

Walkthrough

The setup flow now recognizes fast-browser’s requested-host-missing error. A test verifies that non-interactive setup skips with the existing no-host detail.

Changes

Fast-browser no-host handling

Layer / File(s)	Summary
No-host detection and validation lib/setup/steps/tools.ts, lib/setup/__tests__/steps-c.test.ts	NO_HOST_STDERR matches the requested-host-missing message. The test verifies that non-interactive setup skips with the existing no-host detail.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to cb8a7

The update correctly skips only recognized no-host failures in non-interactive setup while preserving other errors.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the fastbrowser.setup behavior and the change for requested-host-absent wording. It matches the main change.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}