vm walkthrough: unlock the tester keychain before the assert phase - #310
Merged
Merged
Conversation
…s screens already does Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2.9.0 walkthrough's assert phase failed on its first run of the new state-backup assertions: assert-installed.sh runs over SSH where the login keychain is locked, so
rt state backup inithitsecurityexit 36 and correctly refused to mint an age key blind. The screens phase (walkthrough.sh:222) already unlocks the keychain before its SSH command; the assert invocation (line 243) is the only SSH leg that forgot to. This mirrors the exact idiom from line 222.The product behaved correctly (refusing to mint when the keychain is unreachable protects an existing key); this is purely a harness-environment fix.
🤖 Generated with Claude Code