Skip to content

vm walkthrough: unlock the tester keychain before the assert phase - #310

Merged
m4ttheweric merged 1 commit into
mainfrom
vm-assert-keychain-unlock
Sep 17, 2026
Merged

m4ttheweric merged 1 commit into
mainfrom
vm-assert-keychain-unlock

Conversation

@m4ttheweric

Copy link
Copy Markdown
Collaborator

The v2.9.0 walkthrough's assert phase failed on its first run of the new state-backup assertions: assert-installed.sh runs over SSH where the login keychain is locked, so rt state backup init hit security exit 36 and correctly refused to mint an age key blind. The screens phase (walkthrough.sh:222) already unlocks the keychain before its SSH command; the assert invocation (line 243) is the only SSH leg that forgot to. This mirrors the exact idiom from line 222.

The product behaved correctly (refusing to mint when the keychain is unreachable protects an existing key); this is purely a harness-environment fix.

🤖 Generated with Claude Code

…s screens already does

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: be450400-c524-4e9d-b37d-37636aadf42a

📥 Commits

Reviewing files that changed from the base of the PR and between 86cdcd5 and 405425f.

📒 Files selected for processing (1)
  • rt-tray/vm/run/walkthrough.sh

Comment @coderabbitai help to get the list of available commands.

@m4ttheweric
m4ttheweric merged commit fe5ca18 into main Sep 17, 2026
4 checks passed
@m4ttheweric
m4ttheweric deleted the vm-assert-keychain-unlock branch September 17, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant