splash: cut the post-settle hold to 0.3s - #315
Conversation
The floor before the splash may fade was the 1.0s animation settle plus a full second of holding the settled mark, which read as a stall rather than as a beat. 0.3s still lets the landed mark register as finished. Dismissal still waits for the later of this floor and the first page load. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe splash screen post-animation hold decreases from 1.0 seconds to 0.3 seconds. The minimum visible duration remains derived from the animation settle time plus this hold. ChangesSplash timing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The splash screen hold is shortened as intended without an identified user-facing or operational regression. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The splash could not fade for 2.0s: 1.0s of estimated drop-in animation plus
1.0s of holding the settled mark. The second second read as a stall rather
than as a beat, so it drops to 0.3s and the floor becomes 1.3s.
Dismissal is unchanged otherwise: still the later of this floor and the
active app's first navigation finishing, still capped at 8s.
One constant and a comment. Skipping the CodeRabbit wait with Matt's
agreement, since there is nothing here for it to read.
🤖 Generated with Claude Code
Summary by CodeRabbit