Skip to content

splash: cut the post-settle hold to 0.3s - #315

Merged
m4ttheweric merged 1 commit into
mainfrom
splash-hold
Sep 17, 2026
Merged

m4ttheweric merged 1 commit into
mainfrom
splash-hold

Conversation

@m4ttheweric

@m4ttheweric m4ttheweric commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator

The splash could not fade for 2.0s: 1.0s of estimated drop-in animation plus
1.0s of holding the settled mark. The second second read as a stall rather
than as a beat, so it drops to 0.3s and the floor becomes 1.3s.

Dismissal is unchanged otherwise: still the later of this floor and the
active app's first navigation finishing, still capped at 8s.

One constant and a comment. Skipping the CodeRabbit wait with Matt's
agreement, since there is nothing here for it to read.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Reduced the delay after the splash screen animation completes, allowing the app to proceed more quickly while preserving the animation’s minimum visible duration.

The floor before the splash may fade was the 1.0s animation settle plus a
full second of holding the settled mark, which read as a stall rather than
as a beat. 0.3s still lets the landed mark register as finished. Dismissal
still waits for the later of this floor and the first page load.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 26f51d45-61f9-408f-a8bb-45d0e60ddff8

📥 Commits

Reviewing files that changed from the base of the PR and between 979ace0 and 6047bfb.

📒 Files selected for processing (1)
  • rt-tray/Sources/Window/SplashView.swift

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The splash screen post-animation hold decreases from 1.0 seconds to 0.3 seconds. The minimum visible duration remains derived from the animation settle time plus this hold.

Changes

Splash timing

Layer / File(s) Summary
Post-settle hold adjustment
rt-tray/Sources/Window/SplashView.swift
SplashTuning.postSettleHold changes to 0.3 seconds. The explanatory comments describe the shorter settled-mark display interval.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6047b

The splash screen hold is shortened as intended without an identified user-facing or operational regression.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: reducing the splash screen post-settle hold to 0.3 seconds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@m4ttheweric
m4ttheweric merged commit 67fd19d into main Sep 17, 2026
4 checks passed
@m4ttheweric
m4ttheweric deleted the splash-hold branch September 17, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant