watchdog: a done job's live follow-up round suppresses the close nag - #320
Merged
Merged
Conversation
Twice in one day the nag prescribed rt herd close for a job whose consumed report had a follow-up round in flight. The report clocks now stand down while the pane is working, pace off silence since the last observed activity rather than the superseded report, and the remedy asks the shepherd to confirm no round is in flight before closing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twice in one day the watchdog poked the shepherd with "done with report Xm ago, not yet closed; run rt herd close" while the consumed report had a follow-up round actively running in the same pane. Closing on that advice would have killed a live job both times.
The report clocks (worker nag + shepherd backstop) now stand down entirely while the job's pane is WORKING, and otherwise pace off quiet time since the pane's last observed transition when that is newer than the report, so a consumed report a live round superseded no longer drives the nag. The evidence names both ages ("report Xm ago, quiet Ym") and the remedy asks the shepherd to confirm no round is in flight before closing, instead of prescribing a bare close on a premise the watchdog cannot verify.
Verified: full daemon suite green, watchdog e2e green, repo-purity green.
🤖 Generated with Claude Code