Skip to content

Pane-bound notification clicks stop popping the shell window - #369

Merged
m4ttheweric merged 1 commit into
mainfrom
notif-click-no-window-pop
Sep 22, 2026
Merged

m4ttheweric merged 1 commit into
mainfrom
notif-click-no-window-pop

Conversation

@m4ttheweric

Copy link
Copy Markdown
Collaborator

Notification click to a pane no longer raises the window first

Clicking a notification activates the app, and with no visible window the reopen handler shows the shell... so a gate_pane click flashed the window before jumping to the pane.

What changed

  • NotificationClick.Route.suppressesActivationShow: pane and no-op routes suppress; window-bound routes (URL, panels) do not
  • NotificationManager.follow arms a 2s suppression on AppDelegate before a suppressing route; applicationShouldHandleReopen honors it

Testing

New check covering the route matrix; full swift test green.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 79 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f85f5fe3-80db-49c5-992c-55b9c49b8d5f

📥 Commits

Reviewing files that changed from the base of the PR and between c1f83d2 and 517a02a.

📒 Files selected for processing (4)
  • rt-tray/Sources-core/Launch/NotificationClick.swift
  • rt-tray/Sources/AppDelegate.swift
  • rt-tray/Sources/NotificationManager.swift
  • rt-tray/Tests/MattstackCoreChecks/NotificationClickChecks.swift

Comment @coderabbitai help to get the list of available commands.

@m4ttheweric

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@m4ttheweric
m4ttheweric merged commit 483e83e into main Sep 22, 2026
6 checks passed
@m4ttheweric
m4ttheweric deleted the notif-click-no-window-pop branch September 22, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant