Skip to content

rt-client 0.31.1: rt.notifications defaults every event to on - #426

Merged
m4ttheweric merged 1 commit into
mainfrom
rt-client-0.31.1-notification-defaults
Sep 24, 2026
Merged

m4ttheweric merged 1 commit into
mainfrom
rt-client-0.31.1-notification-defaults

Conversation

@m4ttheweric

Copy link
Copy Markdown
Collaborator

the console draws an unset notification toggle from the effective value, and rt.notifications had no registry default, so unset read as off while the daemon sends (loadNotificationPrefs defaults every type to true). the registry now carries that default, keyed by a list the parity test pins against NOTIFICATION_TYPES and settings-kit's NOTIFICATION_EVENTS. no console change needed: it already renders a default explain row with the effective value and a default badge.

🤖 Generated with Claude Code

…et reads as the daemon treats it

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 36 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b6b7b328-e8f9-452c-94c1-8d85096a9d8c

📥 Commits

Reviewing files that changed from the base of the PR and between 3388c7a and de4926e.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • lib/__tests__/notification-shape-parity.test.ts
  • packages/rt-client/package.json
  • packages/rt-client/src/index.ts
  • packages/rt-client/src/settings/__tests__/resolve.test.ts
  • packages/rt-client/src/settings/notification-events.ts
  • packages/rt-client/src/settings/registry-defs.ts

Comment @coderabbitai help to get the list of available commands.

@m4ttheweric
m4ttheweric merged commit d914649 into main Sep 24, 2026
6 checks passed
@m4ttheweric
m4ttheweric deleted the rt-client-0.31.1-notification-defaults branch September 24, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant