update-machine: read deck's real list table through the bundle's deck (RT-274) - #430
Conversation
… (RT-274) deck has no JSON list, so managed apps now come from the table's owner column, with the same owner set `deck restart --managed` kicks. Every leg and the verify sweep call the serving bundle's Contents/Helpers/deck (mattstack.app's when the dev app is not running), never a deck on PATH. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Comment |
…undle up front deck list exits 0 with no rows when its API errors, which read as "no managed apps, all fresh"; an empty managed set is now an error. The serving bundle is read from pgrep before the dev-bundle leg and in --verify-only, so a declined or failed dev leg no longer leaves the served suite and verify on the dev bundle's deck. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD
|
Review of record (Opus; CodeRabbit rate limited). Nothing blocked the merge. All four findings are fixed in 69176c3:
The reviewer confirmed the parser against every row shape deck prints (long names, |
The first real
rt release update-machinerun (v2.11.0) marked the served-suite leg and the verify sweep failed on a machine that was fully current.What changed
Deck contract (
lib/release/update-machine.ts)deck list's table instead ofdeck list --json, which deck ignores.user,deck,local, orunregistered: the same setdeck restart --managedrestarts.One deck CLI
Contents/Helpers/deck: the dev app's, ormattstack.app's when the dev app isn't running.deckon PATH, which had been a stale hand-installed 1.0.5.Tests
fixtures/deck-list-1.0.7.txtis captured from this machine's livedeck list.deckand serve the real table format.Verification
bun test lib/release commands/__tests__/release-update-machine.test.ts: 174/174. A livert release update-machine --verify-only --tag v2.11.0from this branch no longer reports a deck problem. It still reports that the daemon is onb983acc07(rt#428, merged after the tag), which is correct.Fixes RT-274.
🤖 Generated with Claude Code
https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD