update-machine: accept a daemon on a later main that contains the release - #438
Conversation
…ease The dev daemon runs the shared checkout, and main keeps moving during a release, so v2.12.0's run halted on a daemon three commits past the tag. A source rev that is not a prefix match now passes when GitHub's compare reports it ahead of (or identical to) the released commit; behind, diverged, a failed compare, or a non-sha rev still fail closed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 83 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
…e cause A pushed lane branch rebased onto the release contains it without being merged; the check now also requires main to contain the daemon's rev. A compare 404 points at an unpushed shared checkout. Tests pin the non-sha guard and the verify leg's real reasons. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD
|
Review of record (Opus; CodeRabbit rate limited). No blockers; all five findings are fixed.
Also confirmed by the reviewer: the compare direction (live
|
v2.12.0's
rt release update-machinehalted on the daemon leg. Main had moved three commits past the tag, and the dev daemon runs the shared checkout, so it reportedacf3442fainstead of the tag's6acb57807.What changed
Source-rev check (
lib/release/update-machine.ts,daemonRevCheck)aheadoridenticalpasses ("daemon restarted on acf3442, which contains v2.12.0").behind,diverged, a failed compare call, or a source rev that isn't a sha all fail closed, naming the reason.Verification
bun test lib/release commands/__tests__/release-update-machine.test.ts: 217/217, including new cases for ahead, behind, diverged and a failed compare.rt release update-machine --verify-only --tag v2.12.0on this Mac (daemon onacf3442fa) now reads clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017A8MG18FT27cFsiEWiKGHD