tray: let Sparkle's install quit through the window-close interception

[m4ttheweric]

Summary

Install and Relaunch now works on the first click when the mattstack window is open. Before this, the app turned Sparkle's quit into a window close, and the update only installed once a quit came in with the window already closed.

Root cause

To install, Sparkle's installer sends the app an ordinary quit event (NSRunningApplication.terminate) with no kAEQuitReason. applicationShouldTerminate hands every quit to QuitReason.shouldTerminate. That function cancels any quit that isn't from the tray menu or the OS while the window is on screen. So the app closed its window and cancelled Sparkle's quit. Sparkle kept waiting, and each retry of Install and Relaunch hit the same interception.

Fix

• QuitReason.shouldTerminate takes two new inputs: updateInstalling and senderBundleIdentifier. The app terminates when an update is installing and the quit came from Sparkle's installer agent (org.sparkle-project.Sparkle.Updater, as in the bundled Updater.app Info.plist). A Cmd-Q, which has no AppleEvent, or a Dock quit still closes the window, even if the flag outlives a failed install.
• AppDelegate reads the quit event's keySenderPIDAttr and gets the sender's bundle id from NSRunningApplication(processIdentifier:). Updater.app is started with SMJobSubmit, but its main calls NSApplication.sharedApplication, so it registers with LaunchServices. Today's unified log shows launchservicesd CHECKIN ... org.sparkle-project.Sparkle.Updater for the installer run. While an update is installing, every quit logs quit during update install with the sender and the decision.
• UpdaterController sets the flag in updater(_:willInstallUpdate:) and clears it in updater(_:didFinishUpdateCycleFor:error:). AppDelegate gets the flag through a callback and doesn't read updater, because touching that lazy property would start Sparkle on a copy that's only quitting.

Why willInstallUpdate (checked against the Sparkle 2.10.0 source):

• SPUInstallerDriver.installWithToolAndRelaunch calls installerWillFinishInstallationAndRelaunch, which fires updater(_:willInstallUpdate:) and then updaterWillRelaunchApplication(_:). It does this on the main thread, before it sends SPUResumeInstallationToStage2. The installer only sends the quit after stage 2 (AppInstaller.performStage2Installation then sendTerminationSignal), so the flag is always set before the quit arrives.
• willInstallUpdate fires whether or not Sparkle relaunches the app. updaterWillRelaunchApplication only fires on a relaunch.
• Sparkle calls it once per session (_notifiedDelegateInstallationWillFinish) and doesn't call it again when Install and Relaunch is retried. That's why the flag stays set until the update cycle ends and isn't reset after each quit.
• Every install route goes through installWithToolAndRelaunch: the Install and Relaunch button, the retry button, a resumed update, and the immediateInstallationBlock from willInstallUpdateOnQuit. Plain install-on-quit sends no quit from Sparkle. It waits for the app to exit.
• The update cycle only finishes before the quit when the install fails, so clearing the flag there turns the window-close interception back on after a failed install.

Verification

• New checks: with the window on screen, Sparkle's installer quitting during an install terminates the app. With the window on screen, the window still closes for any of these:

  • an install is running and the quit is a plain Cmd-Q, which has no sender;
  • an install is running and the Dock sends the quit;
  • Sparkle's installer sends a quit when no install is running.

  Each new check failed before its fix.

• swift build --package-path rt-tray is green.

• swift run --package-path rt-tray mattstack-checks passes 528 checks with 0 failures.

• UpdaterController names both hooked SPUUpdaterDelegate selectors with #selector, so a Sparkle rename fails the build. I checked that a misspelled selector does fail to typecheck against the framework.

• Not run: a real Sparkle install in the app. That needs a signed build and an appcast.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 85 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b20db2c7-b226-4414-8f69-b0ef21dd111f

📥 Commits

Reviewing files that changed from the base of the PR and between e8e9af4 and df49569.

📒 Files selected for processing (4)

• rt-tray/Sources-core/Launch/QuitReason.swift
• rt-tray/Sources/AppDelegate.swift
• rt-tray/Sources/Updates/UpdaterController.swift
• rt-tray/Tests/MattstackCoreChecks/QuitReasonChecks.swift

---

_{Comment @coderabbitai help to get the list of available commands.}