tray: review changes in its own window; keep rows busy until the list refresh lands - #458
Merged
Merged
Conversation
Review opens a resizable window (one, retargeted per row) instead of a sheet capped by the Worktrees window. Each file is a disclosure header on the card colour over a neutral diff body; all start collapsed, and option-click opens or closes them all. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A finished action cleared the row's busy state on the daemon's reply, then waited seconds for the triage query, so a disposed row sat at rest looking untouched. Rows now stay busy until a query started after the action applies (or fails), via TriageSettleLedger. Clean up N safe does the same and skips rows already busy. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 85 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Comment |
- a fresh identity per Review show, and teardown on close, so the same row reviewed again reloads its diff instead of acting on the old one - close the review window from the panel's willClose (onDisappear never fires for the reused panel window) - disable the review buttons while the row is busy or a bulk clean runs - let loading/failed states shrink with the window - a settle waiter always forces its query; bulk skips busy rows in the view too; catalog fixture lists charlie's three files Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review uncommitted changes now opens in its own resizable window with every file collapsed, and a worktree row stays busy after an action until the refreshed list actually drops or moves it.
What changed
Review window (
WorktreeReviewWindow.swift,WorktreeReviewSheet.swift)dismissfor anonClosethe window host owns; the panel closing closes it tooBusy until the list lands (
WorktreePanelController.swift,Triage.swift)TriageSettleLedger: a finished action waits on the query started after it, applied rows release earlier waiters, a failed query only its ownAlso
review-sheet-expandedsnapshotVerification
TriageSettleLedgerexisted;mattstack-checks529/529 green🤖 Generated with Claude Code