-
Notifications
You must be signed in to change notification settings - Fork 0
glance-react: private; it publishes nowhere now #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,15 @@ | ||
| # Releasing @mattstack/glance and @mattstack/glance-react | ||
| # Releasing @mattstack/glance | ||
|
|
||
| glance is consumed inside this repo as `workspace:*` and glance-react has | ||
| no in-repo consumer yet; a publish exists only for a consumer outside it. | ||
| glance is consumed inside this repo as `workspace:*`; a publish exists only | ||
| for a consumer outside it (the npm-installed `@mattstack/gitq` resolves it | ||
| from the registry). glance-react is private and publishes nowhere; its npm | ||
| versions are deprecated. | ||
| Publish from a checkout on `main`, | ||
| from the package directory, with `bun publish` and never `npm publish`: | ||
| glance-react depends on glance as `workspace:*`, which bun rewrites to the | ||
| version in the tree and npm ships verbatim. | ||
| bun rewrites `workspace:*` dependencies to the version in the tree and npm | ||
| ships them verbatim. | ||
|
|
||
| 1. Bump `version` in the package's `package.json` and add a CHANGELOG entry. | ||
| 2. `bun run build` in the package, then `bun run check-types`. | ||
| 3. `bun publish` (OTP prompt). For glance-react, glance's current version must | ||
| already be on npm: `npm view @mattstack/glance@<version> version`. | ||
| 3. `bun publish` (OTP prompt). | ||
| 4. Commit the bump: `glance: publish <version>`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.