plugins/mattstack: name the three misplaced skills public; dry-run compile in CI - #544
Merged
Merged
Conversation
…public Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… from surface.jsonc fails; 0.27.3 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 84 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Comment |
…ist process-digraphs in the plugin description Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rt skills compileexited 1 on clean main with threemisplaced:notices. The skills were misplaced, and the exit code is correct: this names them insurface.jsoncand adds a CI step so the gap cannot come back.Why each notice fired
creating-a-packandextending-a-packwere added in 0.20.0 (docs: suite settings spec, re-root spec (ruled 2026-08-21) and plan #15), andprocess-digraphsin 0.25.0 (MAT-383 (L1): rt setup verbs — plan, apply, team, uninstall #32).plugins/mattstack/plugin/skills/, whichplugin.jsonregisters as a skill root, so they are slash-menu skills.surface.jsonc's public list was never updated for them, so compile's misplaced scan counts each one as registered but not public.Why fix the files, not the exit code
commands/skills.ts: "An errored or misplaced verb is a failed compile").plugin.json's description names creating-a-pack and extending-a-pack as public doors, and other skills cite process-digraphs by name as a gate skill.attachments/(what the notice suggests) would take them off the slash menu.What changed
surface.jsoncnames all three publicplugin-mattstackjob adds askills compile --dry-runstep, because CI ran onlyskills check, which never reports misplaced skillsplugin.jsongoes to 0.27.3Verification
skills compile --dry-runexits 1 on the oldsurface.jsonc, with the three notices.--jsonverb rows are identical before and after; onlymisplacedempties.skills check --strictstill exits 0.no-plugin-ci-jobsandscripts/citests pass (65 of 65).🤖 Generated with Claude Code