Skip to content

plugins/mattstack: name the three misplaced skills public; dry-run compile in CI - #544

Merged
m4ttheweric merged 3 commits into
mainfrom
dg-compile-misplaced
Sep 28, 2026
Merged

m4ttheweric merged 3 commits into
mainfrom
dg-compile-misplaced

Conversation

@m4ttheweric

Copy link
Copy Markdown
Collaborator

rt skills compile exited 1 on clean main with three misplaced: notices. The skills were misplaced, and the exit code is correct: this names them in surface.jsonc and adds a CI step so the gap cannot come back.

Why each notice fired

Why fix the files, not the exit code

  • Exiting non-zero on a misplaced skill is compile's documented contract (commands/skills.ts: "An errored or misplaced verb is a failed compile").
  • The three skills are meant to be public. plugin.json's description names creating-a-pack and extending-a-pack as public doors, and other skills cite process-digraphs by name as a gate skill.
  • Moving them to attachments/ (what the notice suggests) would take them off the slash menu.

What changed

  • surface.jsonc names all three public
  • The plugin-mattstack job adds a skills compile --dry-run step, because CI ran only skills check, which never reports misplaced skills
  • plugin.json goes to 0.27.3

Verification

  • Before: skills compile --dry-run exits 1 on the old surface.jsonc, with the three notices.
  • After: it exits 0. The --json verb rows are identical before and after; only misplaced empties.
  • skills check --strict still exits 0.
  • The no-plugin-ci-jobs and scripts/ci tests pass (65 of 65).

🤖 Generated with Claude Code

m4ttheweric and others added 2 commits September 27, 2026 23:19
…public

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… from surface.jsonc fails; 0.27.3

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 84 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 69341bd5-75a1-485a-ade6-1e8869c9f013

📥 Commits

Reviewing files that changed from the base of the PR and between 323c49f and 9f0f906.

📒 Files selected for processing (3)
  • .github/workflows/checks.yml
  • plugins/mattstack/.claude-plugin/plugin.json
  • plugins/mattstack/surface.jsonc

Comment @coderabbitai help to get the list of available commands.

…ist process-digraphs in the plugin description

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@m4ttheweric
m4ttheweric merged commit 992cdc1 into main Sep 28, 2026
15 checks passed
@m4ttheweric
m4ttheweric deleted the dg-compile-misplaced branch September 28, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant