Skip to content

Fix for #32 - #33

Merged
madskristensen merged 2 commits into
madskristensen:masterfrom
MagicAndre1981:modernDotNet
May 23, 2026
Merged

madskristensen merged 2 commits into
madskristensen:masterfrom
MagicAndre1981:modernDotNet

Conversation

@MagicAndre1981

Copy link
Copy Markdown
Contributor

Fix for #32 by bumping "Microsoft.AspNetCore.Mvc" to version 2.3.9 and also adding explicit net8.0;net9.0;net10.0 as TargetFramework and other small changes to get it working in modern .net versions.

- added net8.0;net9.0;net10.0 as TargetFramework
- updated "Microsoft.AspNetCore.Mvc" to version 2.3.9
- added System.Text.RegularExpressions in Version 4.3.1 to netstandard2.0, as transitive version 4.3.0 has at least one vulnerability with high severity

- Sample:
  - added net8.0;net9.0;net10.0 as TargetFramework
  - replaced WebMarkupMin.AspNetCore2 with WebMarkupMin.AspNetCoreLatest
  - replaced services.AddMvc(); with services.AddMvc(options => options.EnableEndpointRouting = false);
  - removed "using Microsoft.AspNetCore.Http.Internal;" call as namespace is not found in modern .net versions
  - removed "app.UseBrowserLink();" as only working until ASP.NET Core 2.2

- updated "Microsoft.AspNetCore.Mvc" to version 2.3.9
- added System.Text.RegularExpressions in Version 4.3.1 to netstandard2.0, as transitive version 4.3.0 has at least one vulnerability with high severity

- Sample:
  - added net8.0;net9.0;net10.0 as TargetFramework
  - replaced WebMarkupMin.AspNetCore2 with WebMarkupMin.AspNetCoreLatest
  - replaced services.AddMvc(); with services.AddMvc(options => options.EnableEndpointRouting = false);
  - removed "using Microsoft.AspNetCore.Http.Internal;" call as namespace is not found in modern .net versions
  - removed "app.UseBrowserLink();" as only working until ASP.NET Core 2.2
@MagicAndre1981

Copy link
Copy Markdown
Contributor Author

ok, looks like appveyor misses VS2026 / .net10 support so CI fails.

@MagicAndre1981

Copy link
Copy Markdown
Contributor Author

ok, installing .NET10 SDK works and CI is green now.

@madskristensen
madskristensen merged commit 41a0255 into madskristensen:master May 23, 2026
1 check passed
@madskristensen

Copy link
Copy Markdown
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants