example fix and color customisation support - #1
Conversation
fix missing Dep react-native-root-modal; install Dep react-native-root-toast from lib root.
| "dependencies": { | ||
| "react-native": "^0.20.0", | ||
| "react-native-root-toast": "^0.0.1" | ||
| "react-native-root-toast": "../", |
There was a problem hiding this comment.
Thanks for this PR. 👍
But I have one question for this.
Im not quite understand why should change the dependcy of react-native-root-toast to relative path. Wouldnt it be better that the example can be installed independently?
There was a problem hiding this comment.
Hi, I keep seeing this structure elsewhere and I guess it may be only a convenience for contributors to also test the example project after they did any changes to the lib (needs npm uninstall this lib and re npm install), because they won't have an updated npm module of this lib to npm install before it's merged and officially published;
and a normal lib user would most possibly clone the whole repository and install from within the example subfolder, while he should also know how to change the version if he really want the example to be installed independently cause it's very basic.
Anyway I am still a learner of RN, please feel free to take any changes you like :)
|
Color customization looks great, looking forward to see this merged when possible! |
|
Thanks for this PR 👍 |
add prop-types in dependencies
replaced legacy methods: componentWillMount, componentWillReceiveProps
3 participants
:)