fix transform for perspective views - #1114
Merged
Merged
Conversation
Adds a mock container so that transform.size is not 0. When the transform has a size, `setBearingAround` results are constrianed so that the map fits the view. This adds two new tests for the constrained case, and modifies the reset so that they test unconstrained rotation.
It turns out that there was a wrong 1px z translation later on.
pointCoordinate and coordinatePoint now use the position matrices so that they are identical to the rendered positions. This makes them work in perspective view. Some test values are now rounded 10 decimal points to allow for slight differences.
zooming and panning in perspective view. fixes #917
ansis
added a commit
that referenced
this pull request
Mar 20, 2015
fix transform for perspective views
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1088
fixes #1053
fixes #917
Transform now uses the projection matrix to do conversions to and from points.