Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Add MGLMapViewZoomTests and clean-up other gesture tests - #15117

Merged
friedbunny merged 3 commits into
masterfrom
friedbunny-adds-pinch-gesture-tests-and-such
Jul 17, 2019
Merged

[ios] Add MGLMapViewZoomTests and clean-up other gesture tests#15117
friedbunny merged 3 commits into
masterfrom
friedbunny-adds-pinch-gesture-tests-and-such

Conversation

@friedbunny

@friedbunny friedbunny commented Jul 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

/cc @julianrex @astojilj

@friedbunny friedbunny added iOS Mapbox Maps SDK for iOS tests labels Jul 13, 2019
@friedbunny friedbunny added this to the release-picklejuice milestone Jul 13, 2019
@friedbunny
friedbunny requested review from a team and julianrex July 13, 2019 01:01
@friedbunny friedbunny self-assigned this Jul 13, 2019
@friedbunny
friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 3448860 to 15595cb Compare July 13, 2019 01:04
friedbunny
friedbunny commented Jul 13, 2019
View reviewed changes
Comment thread platform/ios/test/MGLMapViewZoomTests.m Outdated
friedbunny
friedbunny commented Jul 13, 2019
View reviewed changes
Comment thread platform/ios/test/MGLMapViewZoomTests.m
return pow(2, zoom);
}

__unused NS_INLINE double MGLZoomLevelFromScale(CGFloat scale) {

@friedbunny friedbunny Jul 13, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not currently used, but could be useful in future.

friedbunny
friedbunny commented Jul 13, 2019
View reviewed changes
Comment thread platform/ios/test/MGLMapViewZoomTests.m Outdated
@friedbunny
friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 15595cb to 0f0af1f Compare July 15, 2019 20:17
@friedbunny
friedbunny force-pushed the friedbunny-adds-pinch-gesture-tests-and-such branch from 0f0af1f to 6d4ef21 Compare July 15, 2019 20:31
astojilj
astojilj approved these changes Jul 17, 2019
View reviewed changes

@astojilj astojilj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@friedbunny
friedbunny merged commit 5b820a9 into master Jul 17, 2019
@friedbunny
friedbunny deleted the friedbunny-adds-pinch-gesture-tests-and-such branch July 17, 2019 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@julianrex julianrex Awaiting requested review from julianrex
1 more reviewer
@astojilj astojilj astojilj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@friedbunny friedbunny

Labels

iOS Mapbox Maps SDK for iOS tests

Projects

None yet

Milestone

release-picklejuice

Development

Successfully merging this pull request may close these issues.

2 participants

@friedbunny @astojilj