Skip to content

Show Error dialog when export-to-image fails to save - #4397

Merged
bjorn merged 5 commits into
mapeditor:masterfrom
kunal649:fix/export-as-image-silent-failure
Mar 11, 2026
Merged

bjorn merged 5 commits into
mapeditor:masterfrom
kunal649:fix/export-as-image-silent-failure

Conversation

@kunal649

@kunal649 kunal649 commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Fixes an Issue #4396 where File → Export as Image would silently close the dialog if the image could not be saved, giving the user no feedback about the failure.

The return value of QImage::save() was not being checked. this commit wraps the call in an error check and shows a warning dialog if saving fails, consistent with how other export operations handle errors in Tiled.

thanks :-)

Screenshot 2026-03-06 115817

Comment thread src/tiled/exportasimagedialog.cpp Resolved
@kunal649
kunal649 requested a review from bjorn March 6, 2026 13:23
@kody-ai

This comment has been minimized.

@mapeditor mapeditor deleted a comment from kody-ai Bot Mar 11, 2026
@bjorn
bjorn merged commit 8b67a83 into mapeditor:master Mar 11, 2026
13 of 14 checks passed
@bjorn

bjorn commented Mar 11, 2026

Copy link
Copy Markdown
Member

Thanks @kunal649! I've merged this despite the string freeze for Tiled 1.12, because I think an English error is still better than nothing at all. :-)

@kunal649
kunal649 deleted the fix/export-as-image-silent-failure branch March 11, 2026 15:09
@kunal649

Copy link
Copy Markdown
Contributor Author

I'll keep that in mind next time 🙂‍↕️

@bjorn

bjorn commented Mar 11, 2026 •

Copy link
Copy Markdown
Member

Well, there's no need for you to keep the string freeze in mind I guess. Not sure why I mentioned it, but I'm holding off on merging some changes because they add new strings to the UI at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants