Repository navigation
Show Error dialog when export-to-image fails to save - #4397
Merged
bjorn merged 5 commits intoMar 11, 2026
Merged
Conversation
bjorn
reviewed
Mar 6, 2026
This comment has been minimized.
This comment has been minimized.
Member
|
Thanks @kunal649! I've merged this despite the string freeze for Tiled 1.12, because I think an English error is still better than nothing at all. :-) |
Contributor
Author
|
I'll keep that in mind next time 🙂 |
Member
|
Well, there's no need for you to keep the string freeze in mind I guess. Not sure why I mentioned it, but I'm holding off on merging some changes because they add new strings to the UI at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an Issue #4396 where File → Export as Image would silently close the dialog if the image could not be saved, giving the user no feedback about the failure.
The return value of QImage::save() was not being checked. this commit wraps the call in an error check and shows a warning dialog if saving fails, consistent with how other export operations handle errors in Tiled.
thanks :-)