Repository navigation
Keep the tileset menu in one scrollable column - #4635
Open
vtxe02023274 wants to merge 1 commit into
Open
vtxe02023274 wants to merge 1 commit into
vtxe02023274 wants to merge 1 commit into
Conversation
With many tilesets the menu grew into columns that went past the edge of the screen, so tilesets on the right could not be picked. Closes mapeditor#4558
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4558
When a menu has more items than fit on the screen, Qt lays it out in more columns instead of making it scroll, so with many tilesets the tileset menu grew sideways past the edge of the screen. The tileset menu now sets
menu-scrollable, so it stays one column and scrolls like a long menu does on macOS.I used a style sheet with only that property instead of a proxy style, since a proxy would be built around the style at startup and the style can change in the preferences.
Tested with a small Qt 6.8 program on Windows:
menu-scrollable: one column, 169 px wide.Tiled itself builds with the change; I did not set up a project with hundreds of tilesets to click through it.
#4589 makes the tab bar itself scroll. This one is about the menu from the button in the screenshot of #4558, which overflows on its own, so the two do not overlap.