make ui compatible with new single task lock functionality - #2899
Open
CollinBeczak wants to merge 7 commits into
Open
make ui compatible with new single task lock functionality#2899CollinBeczak wants to merge 7 commits into
CollinBeczak wants to merge 7 commits into
Conversation
The backend now allows a user only one active task lock at a time and returns 409 with the held lock's details when a second lock attempt conflicts. Add getLockConflict to parse that response and a useLockConflict hook that shows LockConflictModal, releases the held task via the existing unlock endpoint, and retries the original action on confirm. Wire it into TaskContext's auto-lock/manual lock and into TaskActionModal's bundle create/update flow, and add bundledTasks to the LockedTaskData type.
…xt lock-clearing
Dedupe the repeated navigate({ to: '/tasks/$taskId', ... claimTask: true }) call across
task-start/skip/nearby/random navigation and the lock-conflict dialog into a single
useNavigateToTask hook. Also collapse the three near-identical inline lock-clearing
callbacks in TaskContext into one clearLockState helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr also includes some other miscellaneous work due to me debugging issues as i found them when getting the ui to work properly. Will keep future pr's more focused.