Fix duplicate undoable mutation commits on notification exit - #11345
Open
dawNotPoi wants to merge 1 commit into
Open
Fix duplicate undoable mutation commits on notification exit#11345dawNotPoi wants to merge 1 commit into
dawNotPoi wants to merge 1 commit into
Conversation
dawNotPoi
marked this pull request as ready for review
August 22, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With MUI 6 and later,
Notificationpasses the sameonExitedcallback through both the legacyTransitionPropsAPI andslotProps.transition. MUI invokes both callbacks, causing an undoable mutation to be committed twice.Fixes #11334
Solution
Use
TransitionPropsandContentPropsonly with MUI 5. For MUI 6 and later, use the slot props API exclusively while preserving the existing user prop override order.How To Test
yarn jest packages/ra-ui-materialui/src/layout/Notification.spec.tsx --runInBandyarn jest packages/ra-core/src/notification/useNotify.spec.tsx --runInBandyarn workspace ra-core buildyarn workspace ra-ui-materialui buildyarn tsc --noEmit -p packages/ra-ui-materialui/tsconfig.jsonAdditional Checks
masterfor a bug fix