You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe alternatives you've considered
I have looked into the optional keyword arguments scaler_parameters and scaler_snapshots, they are used by calling their method fit_transform. I did not find any definition of fit_transform or how the scalers are supposed to be used.
I am happy to contribute if you think that fits in your library and is not already possible in some other way.
I figured out that this must be for the StandardScaler from scikit-learn. I think this could be better documented.
In the database class documentation, the scaler_parameters and scaler_snapshots should be removed, since they are no longer used.
(In older versions, fit_transform was called every time parameters or snapshots were referenced, meaning the scaler may change which can lead to unexpected behaviour...)
In the DatabaseScaler class, the StandardScaler should probably be referenced. It would be great to have an example how to use this plugin.
I wondered if the scalers (scaler_parameters and scaler_snapshots) from the database should be removed elsewhere (e.g. in the ROM) as well? I think it was a good idea to separate the scaling from the ROM.
Is database.parameters (and .snapshots) considered to be deprecated now in favour for database.parameters_matrix?
Activity
flabowski commentedon Aug 26, 2024
I figured out that this must be for the
StandardScalerfrom scikit-learn. I think this could be better documented.scaler_parametersandscaler_snapshotsshould be removed, since they are no longer used.(In older versions,
fit_transformwas called every timeparametersorsnapshotswere referenced, meaning the scaler may change which can lead to unexpected behaviour...)I wondered if the scalers (
scaler_parametersandscaler_snapshots) from the database should be removed elsewhere (e.g. in the ROM) as well? I think it was a good idea to separate the scaling from the ROM.Is
database.parameters(and .snapshots) considered to be deprecated now in favour fordatabase.parameters_matrix?flabowski commentedon Jan 6, 2025
any thoughts @ndem0, do you have an example how to use the scaler plugin?