Skip to content

fix(test): repair pnpm test:* scripts pointing to missing files - #247

Open
axisrow wants to merge 1 commit into
matt1398:mainfrom
axisrow:fix/test-scripts
Open

axisrow wants to merge 1 commit into
matt1398:mainfrom
axisrow:fix/test-scripts

Conversation

@axisrow

@axisrow axisrow commented Oct 11, 2026 •

Copy link
Copy Markdown

Summary

  • All four legacy tsx scripts (test:chunks, test:semantic, test:noise, test:task-filtering) fail with ERR_MODULE_NOT_FOUND — the test/test-*.ts entry files were never committed to the repo.
  • test:chunks → vitest run test/main/services/analysis/ChunkBuilder.test.ts (chunk building)
  • test:noise → vitest run test/main/services/parsing/MessageClassifier.test.ts (noise classification)
  • test:semantic and test:task-filtering removed: no vitest coverage of those areas exists to redirect to.
  • CLAUDE.md and .claude/rules/testing.md updated to reference only working commands.

Tests

The identical change is verified green in my fork (axisrow#108): pnpm test:chunks 18 passed, pnpm test:noise 22 passed, full suite 972 passed, typecheck clean. Both target files exist in this repo and match the test/**/*.test.ts include in vitest.config.ts.

Closes #246

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests

    • The chunk-building and noise-filtering test commands now run their respective test files with Vitest, with descriptions clarifying the areas they cover.
    • The semantic step-extraction and Task tool filtering test commands have been removed.
  • Documentation

    • The documented test command list now reflects these changes.

All four legacy tsx scripts fail with ERR_MODULE_NOT_FOUND - their
target test/test-*.ts files were never committed to the repo.

- test:chunks -> vitest run test/main/services/analysis/ChunkBuilder.test.ts
- test:noise  -> vitest run test/main/services/parsing/MessageClassifier.test.ts
- test:semantic, test:task-filtering removed: no vitest coverage of
  those areas exists to redirect to
- CLAUDE.md and .claude/rules/testing.md updated to match

Co-Authored-By: Claude Code <noreply@anthropic.com>
@coderabbitai coderabbitai Bot added bug Something isn't working documentation Improvements or additions to documentation labels Oct 11, 2026
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8eaa7ecd-1721-47ac-8b78-29b4d5021ad2

📥 Commits

Reviewing files that changed from the base of the PR and between 1486f20 and 8bd8ef1.


📒 Files selected for processing (3)
  • .claude/rules/testing.md
  • CLAUDE.md
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The chunk and noise test scripts now run existing Vitest test files. The semantic and task-filtering scripts were removed. The command documentation names the test targets and reflects the removed scripts.

Changes

Test command updates

Layer / File(s) Summary
Test script targets and command documentation
package.json, CLAUDE.md, .claude/rules/testing.md
The chunk and noise scripts now run Vitest on ChunkBuilder.test.ts and MessageClassifier.test.ts. The semantic and task-filtering scripts and documentation entries were removed. The remaining command descriptions name their corresponding components.

Suggested labels: bug, documentation


Priority: ⬇️ Low

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 8bd8e

The chunk and noise test commands now target existing tests, and the removed commands are no longer referenced in tracked files. No material merge-readiness concern is evident.

Pre-merge checks | Passed 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check Passed Issue #246 requires four broken scripts to be corrected. package.json now maps test:chunks to ChunkBuilder.test.ts and test:noise to MessageClassifier.test.ts. It removes test:semantic and…
Out of Scope Changes check Passed The available change summary lists changes only in package.json, CLAUDE.md, and .claude/rules/testing.md. Each change directly supports issue #246 by correcting test commands or synchronizing te…

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm test:chunks / test:semantic / test:noise / test:task-filtering fail - entry files were never committed

1 participant