Push events: option to show commit author instead of committer

[cpatulea]

Hi, we have enabled Github integration in our Mattermost instance and enjoy it.

For example we received this push event:

but, the commit was not authored by me, it was authored by someone else: FOULAB/foulab-dot-org-hugo@f35cb83

We would like the original author in the notifications. Would it be possible to have an option for that?

I believe the template is here:

mattermost-plugin-github/server/plugin/template.go

Line 273 in d8fb001

template.Must(masterTemplate.New("pushedCommits").Funcs(funcMap).Parse(`

[cpatulea]

Here's a high level draft: b3024fa

Does this seems like a good approach? If so, I'll go through the contribution guidelines in more detail and submit a formal PR.

[hanzei]

@raghavaggarwal2308 Can you please provide guidance here for the next steps?

[raghavaggarwal2308]

@hanzei @cpatulea The approach looks fine to me. We can properly review the commit once the PR is submitted.

As a next step, you can submit a PR against the master branch. You can take reference from this #718 PR and add the necessary info in the description.

[cpatulea]

Thanks for the merge!

What's the general release process for mattermost-plugin-github? We're currently running stable v2.1.7 - would this feature be backported to the 2.1 branch? I also see a v2.2.0-rc3, what's a typical timeline for those to become stable?

[mickmister]

@cpatulea We're discussing whether we will include this in v2.2.0. I'm thinking we will. We are cutting a new RC once we finalize what to include in this version, and then running it on https://community.mattermost.com for a week to ensure stability, and then cutting the stable release

[cpatulea]

For my own reference, looks like this was released in v2.2.0 on Feb 13: https://github.com/mattermost/mattermost-plugin-github/releases/tag/v2.2.0