mm-241 - adds aria labels to right hand side elements by maisnamrajusingh · Pull Request #462 · mattermost/mattermost-plugin-github

maisnamrajusingh · 2021-07-26T13:23:38Z

Summary

Hovering over the elements on the right hand side should display the labels for those items.

Ticket Link

mattermod · 2021-07-26T13:23:42Z

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

larkox

LGTM

hanzei

LGTM 👍

hanzei

Should the PR/Issue title also have a label?

hanzei · 2021-08-02T12:08:37Z

And what about the milestone icon?

jasonblais · 2021-08-05T15:08:43Z

@hanzei is this ready to merge? Looks like it has two approvals. We can create follow-up tickets for the additional labels and icons?

mickmister

Thanks @maisnamrajusingh, I have a request to reformat some JSX indenting. Also, I agree with @hanzei that we should add the aria-labels to the PR title and milestones, and I would like to add them to the PR/issue labels as well.

mickmister · 2021-08-05T18:55:00Z

+                    <span
+                        title={'Success'}
+                        style={{...style.icon, ...style.iconSucess}}
+                    ><TickIcon/></span>


Can we format the JSX for this block and the two blocks below like this?

Suggested change

<span

title={'Success'}

style={{...style.icon, ...style.iconSucess}}

><TickIcon/></span>

<span

title={'Success'}

style={{...style.icon, ...style.iconSucess}}

>

<TickIcon/>

</span>

@maisnamrajusingh By "and the two blocks below" I meant to apply this change to the two blocks below this block as well. Can you please apply the change to the other two span blocks?

sure, done.

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

codecov-commenter · 2021-08-06T09:37:29Z

Codecov Report

Merging #462 (e8a192c) into master (f585550) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   15.51%   15.51%           
=======================================
  Files          15       15           
  Lines        4151     4151           
=======================================
  Hits          644      644           
  Misses       3465     3465           
  Partials       42       42

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hanzei

Blocking on by questions above: #462 (review)

maisnamrajusingh · 2021-08-12T09:15:31Z

@hanzei I have assigned the changes to @sanjaydemansol He will take a look into it

mickmister · 2021-08-17T03:17:38Z

I'm also blocking on #462 (comment)

mattermod · 2021-08-29T01:00:59Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

maisnamraju · 2021-09-09T08:12:15Z

Should the PR/Issue title also have a label?

I guess it should have one, @sanjaydemansol can you add it.

sanjaydemansol · 2021-09-13T03:16:31Z

Should the PR/Issue title also have a label?

Please elaborate, what should be the content of label?

…lugin-github into mm-241

mickmister · 2022-04-19T23:16:21Z

@mickmister this was an original pr by @sanjaydemansol I am not sure if it was ticked or not. Should I just send a new PR in place of this ?

Since there is already review and dicussion history on this PR, I think it makes sense to finish this one that's in progress

mickmister · 2022-04-19T23:08:00Z

        if (item.milestone) {
            milestone = (
                <span
+                    title={'Milestone'}


Looks like we should have the milestone's name here, based on the discussion in this thread

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

mickmister · 2022-04-27T19:19:18Z

-                status = (<span style={{...style.icon, ...style.iconSucess}}><TickIcon/></span>);
+                status = (
+                    <span
+                        title={'Success'}


I think "Checks Passing" would be more appropriate, but not a required change

mattermod · 2022-10-03T01:01:18Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

hanzei · 2023-02-20T13:37:46Z

/update-branch

mattermost-build · 2023-02-20T13:37:48Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

DHaussermann

Tested and passed

For the area in scope here:
- All title spans have aria labels
- Other spans and divs seem to all have aria label
- All svg images have aria labels
No regressions found

note The initial issue makes mention that some hover effects are missing. While all .svg now have a label this did not solve the problem of missing hover effects on some elements. However, if this is problematic we should open a new issue with specifically where we want text to show on hover. Therefore I believe we should accept this PR as is.

LGTM!

Fixes mattermost#241

329df56

maisnamrajusingh requested a review from hanzei as a code owner July 26, 2021 13:23

larkox approved these changes Jul 27, 2021

View reviewed changes

larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 27, 2021

larkox requested review from DHaussermann and mickmister and removed request for DHaussermann July 27, 2021 08:46

larkox removed the 3: QA Review Requires review by a QA tester label Jul 27, 2021

hanzei approved these changes Aug 2, 2021

View reviewed changes

hanzei added this to the v2.1.0 milestone Aug 2, 2021

hanzei reviewed Aug 2, 2021

View reviewed changes

mickmister suggested changes Aug 5, 2021

View reviewed changes

Update webapp/src/components/sidebar_right/github_items.tsx

9caa886

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

mickmister linked an issue Aug 10, 2021 that may be closed by this pull request

Add aria-labels to RHS elements #241

Closed

hanzei requested changes Aug 12, 2021

View reviewed changes

mattermod added the Lifecycle/1:stale label Aug 29, 2021

re-arrange code

89e4f6e

hanzei assigned sanjaydemansol Sep 3, 2021

hanzei added the Awaiting Submitter Action Blocked on the author label Sep 3, 2021

sanjaydemansol requested a review from mickmister September 13, 2021 03:14

maisnamrajusingh and others added 4 commits April 14, 2022 20:02

Merge branch 'master' into mm-241

2f50001

removed role that caused tooltip lint issue

746aa62

Merge branch 'mm-241' of https://github.com/demansoltech/mattermost-p…

cd8ed08

…lugin-github into mm-241

updated lint error fix

da19992

mickmister suggested changes Apr 19, 2022

View reviewed changes

maisnamrajusingh and others added 3 commits April 21, 2022 16:10

Update webapp/src/components/sidebar_right/github_items.tsx

848e0b1

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

Update github_items.tsx

890ae4e

Update package-lock.json

e8a192c

maisnamrajusingh requested a review from mickmister April 24, 2022 03:45

mickmister approved these changes Apr 27, 2022

View reviewed changes

hanzei requested a review from DHaussermann September 18, 2022 16:47

hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer Awaiting Submitter Action Blocked on the author Lifecycle/1:stale labels Sep 18, 2022

hanzei unassigned maisnamrajusingh Sep 18, 2022

hanzei removed this from the v2.2.0 milestone Sep 20, 2022

mattermod added the Lifecycle/1:stale label Oct 3, 2022

hanzei removed the Lifecycle/1:stale label Feb 20, 2023

hanzei added this to the v2.2.0 milestone Feb 20, 2023

DHaussermann approved these changes Feb 23, 2023

View reviewed changes

DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Feb 23, 2023

hanzei merged commit 84b0428 into mattermost:master Feb 24, 2023

mickmister mentioned this pull request Mar 20, 2023

Release bump v2.2.0 #583

Closed

avas27JTG mentioned this pull request Nov 9, 2023

Bump version to 2.2.0. #709

Merged

Uh oh!

Conversation

maisnamrajusingh commented Jul 26, 2021

Summary

Ticket Link

Uh oh!

mattermod commented Jul 26, 2021

Uh oh!

larkox left a comment

Choose a reason for hiding this comment

Uh oh!

hanzei left a comment

Choose a reason for hiding this comment

Uh oh!

hanzei left a comment

Choose a reason for hiding this comment

Uh oh!

hanzei commented Aug 2, 2021

Uh oh!

jasonblais commented Aug 5, 2021

Uh oh!

mickmister left a comment

Choose a reason for hiding this comment

Uh oh!

mickmister Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

mickmister Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

sanjaydemansol Aug 31, 2021

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hanzei left a comment

Choose a reason for hiding this comment

Uh oh!

maisnamrajusingh commented Aug 12, 2021

Uh oh!

mickmister commented Aug 17, 2021

Uh oh!

mattermod commented Aug 29, 2021

Uh oh!

maisnamraju commented Sep 9, 2021

Uh oh!

sanjaydemansol commented Sep 13, 2021

Uh oh!

mickmister commented Apr 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mickmister Apr 19, 2022

Choose a reason for hiding this comment

Uh oh!

mickmister Apr 27, 2022

Choose a reason for hiding this comment

Uh oh!

mattermod commented Oct 3, 2022

Uh oh!

hanzei commented Feb 20, 2023

Uh oh!

mattermost-build commented Feb 20, 2023

Uh oh!

DHaussermann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

codecov-commenter commented Aug 6, 2021 •

edited

Loading

DHaussermann left a comment •

edited

Loading