Skip to content

Move font color to outer span so it is applied to the overflow text - #596

Merged
hanzei merged 3 commits into
mattermost:masterfrom
shinnlok:MM-331
Feb 23, 2023
Merged

Move font color to outer span so it is applied to the overflow text#596
hanzei merged 3 commits into
mattermost:masterfrom
shinnlok:MM-331

Conversation

@shinnlok

Copy link
Copy Markdown
Contributor

Summary

Screen_Shot_2022-10-23_at_8_15_44_AM

Ticket Link

Fixes #331

@shinnlok
shinnlok requested a review from hanzei as a code owner October 23, 2022 15:42
@mattermod

Copy link
Copy Markdown
Contributor

Hello @shinnlok,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter

codecov-commenter commented Oct 23, 2022

Copy link
Copy Markdown

Codecov Report

Base: 15.63% // Head: 15.80% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (0b27aa4) compared to base (9d6cb4b).
Patch has no changes to coverable lines.

❗ Current head 0b27aa4 differs from pull request most recent head db7716a. Consider uploading reports for the commit db7716a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   15.63%   15.80%   +0.16%     
==========================================
  Files          15       15              
  Lines        5243     4201    -1042     
==========================================
- Hits          820      664     -156     
+ Misses       4380     3494     -886     
  Partials       43       43              
Impacted Files Coverage Δ
server/plugin/permalinks.go 70.37% <0.00%> (-2.83%) ⬇️
server/plugin/flows.go 0.00% <0.00%> (ø)
server/plugin/oauth.go 0.00% <0.00%> (ø)
server/plugin/cluster.go 0.00% <0.00%> (ø)
server/plugin/telemetry.go 0.00% <0.00%> (ø)
server/plugin/mm_34646_token_refresh.go 0.00% <0.00%> (ø)
server/plugin/plugin.go 3.72% <0.00%> (+0.03%) ⬆️
server/plugin/webhook.go 0.95% <0.00%> (+0.08%) ⬆️
server/plugin/command.go 8.33% <0.00%> (+0.17%) ⬆️
server/plugin/template.go 95.60% <0.00%> (+0.46%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 24, 2022

@hanzei hanzei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 👍

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 24, 2022
@hanzei
hanzei requested a review from DHaussermann October 24, 2022 05:38
@mattermod

Copy link
Copy Markdown
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei

hanzei commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

/update-branch

@hanzei

hanzei commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

@DHaussermann Gentle reminder to review the PR

@hanzei

hanzei commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

/update-branch

@DHaussermann DHaussermann left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Using examples provided and other I see that ellipses are styled appropriately
  • As a precaution - checked across multiple themes. There is no change

LGTM!

Huge thanks @shinnlok for fixing this 👍

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Feb 23, 2023
@hanzei
hanzei merged commit 0b7ed4e into mattermost:master Feb 23, 2023
@mickmister mickmister mentioned this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request Contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ellipsis for long, bright labels has wrong color in tooltip

6 participants