Skip to content

Change OAuth complete timeout to 2 minutes - #606

Merged
mickmister merged 2 commits into
masterfrom
oauth-complete-timeout
Dec 2, 2022
Merged

Change OAuth complete timeout to 2 minutes#606
mickmister merged 2 commits into
masterfrom
oauth-complete-timeout

Conversation

@mickmister

Copy link
Copy Markdown
Contributor

Summary

Ticket Link

Fixes #605

@mickmister
mickmister requested a review from hanzei as a code owner November 15, 2022 08:41
Comment thread server/plugin/api.go Outdated
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 16, 2022
@hanzei hanzei added this to the v2.1.4 milestone Nov 16, 2022
@mickmister
mickmister requested a review from hanzei November 16, 2022 20:05
@codecov-commenter

codecov-commenter commented Nov 16, 2022

Copy link
Copy Markdown

Codecov Report

Base: 15.80% // Head: 15.79% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f7f5937) compared to base (ac880fe).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   15.80%   15.79%   -0.01%     
==========================================
  Files          15       15              
  Lines        4201     4203       +2     
==========================================
  Hits          664      664              
- Misses       3494     3496       +2     
  Partials       43       43              
Impacted Files Coverage Δ
server/plugin/api.go 8.24% <0.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mickmister mickmister changed the title Change OAuth complete timeout to 5 minutes Change OAuth complete timeout to 2 minutes Nov 16, 2022
@hanzei hanzei modified the milestones: v2.1.4, v2.1.5 Dec 2, 2022
@hanzei

hanzei commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

@mickmister Should we merge this PR?

@mickmister
mickmister merged commit a01cb87 into master Dec 2, 2022
@mickmister
mickmister deleted the oauth-complete-timeout branch December 2, 2022 18:18
@hanzei hanzei modified the milestones: v2.1.5, v2.2.0 Jan 2, 2023
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 2, 2023
@avas27JTG avas27JTG mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change OAuth complete timeout to 2 minutes

3 participants