[MM-50985] Remove usage of model.AppError - #648
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 15.54% 15.54%
=======================================
Files 15 15
Lines 5476 5469 -7
=======================================
- Hits 851 850 -1
+ Misses 4582 4577 -5
+ Partials 43 42 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hanzei
marked this pull request as ready for review
March 4, 2023 18:39
hanzei
added
2: Dev Review
mickmister
approved these changes
Mar 6, 2023
| if appErr != nil { | ||
| return errors.Wrap(appErr, "failed check whether MM-34646 refresh is already done") | ||
| var data []byte | ||
| err := p.client.KV.Get(mm34646DoneKey, &data) |
Contributor
There was a problem hiding this comment.
Do you think we can rename this var to something else? It doesn't provide much context reading the code
Contributor
Author
There was a problem hiding this comment.
To which variable are you referring?
srkgupta
approved these changes
Mar 9, 2023
Contributor
Author
|
@DHaussermann While there is nothing specific to test for, I would appreciate a general smoke test on the plugin functionality, as the PR touches the whole code base. |
hanzei
changed the title
|
@hanzei The plugin seems to crash when deployed from this build. I have seen this occur locally on
All I did was enable the plugin or try upgrading to this build. The Local logs show the following where I see a panic (I have also attached more logs in a file in case I missed something helpful): |
|
@hanzei please advise on next steps for this. |
DHaussermann
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Tested and passed
- Smoke tested GitHub
- Authentication is working from browser and desktop
- Create and attach are working as expected
- Tested subscription creation and delivery
- Various slash commands to retrieve data
me,todoetc...
- No new error in the server logs found (just the known issue with API rate limit)
- No issues found in dev console or network tab
No regression or changes in behavior found
LGTM!
DHaussermann
added
4: Reviews Complete
trilopin
added a commit
that referenced
this pull request
Apr 17, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on mattermost/mattermost-plugin-api#127
Ticket Link
https://mattermost.atlassian.net/browse/MM-50985