Conversation
m1lt0n
added
2: Dev Review
jupenur
approved these changes
Mar 16, 2023
mickmister
approved these changes
Mar 17, 2023
Merged
|
@m1lt0n I have regression tested the feature that control if code previews should show and if they should also be allowed to show from private repos. For the scope on change on this it's a bit unclear to me please reach out if there is further functional testing applicable. |
DHaussermann
added
QA Review Done
DHaussermann
approved these changes
Mar 20, 2023
DHaussermann
left a comment
DHaussermann
left a comment
There was a problem hiding this comment.
LGTM!
Approved unless Dev has further concerns.
hanzei
added
4: Reviews Complete
trilopin
pushed a commit
that referenced
this pull request
Mar 23, 2023
mickmister
added a commit
that referenced
this pull request
Mar 27, 2023
* disable cgo * bump version 2.1.5 * Bump version to 2.1.5 * [MM-51245] Handle relative paths in permalinks (#656) * [MM-51269] Log errors from telemetry events (#653) * keep telemetry init together and do the enable/disable thing (#659) It places telemetry client and tracker initialization together at onActivate and uses the new enable/disable commands at onConfigurationChange. Also, pass a logger to the telemetry tracker when ServiceSettings.EnableDeveloper is true (through NewTelemetryTracker), which will end up logging the telemetry activity (no matter if the tracking config or client is disabled). This is still 2/5 until backwards-compatibility details are discussed. Added event account_connected when we have an oauth successful connection (through setup or plain connect). * run ci on release branches * remove check for release branch * add nvmrc * add cd workflow --------- Co-authored-by: Pantelis Vratsalis <pvratsalis@gmail.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com> Co-authored-by: José Peso <trilopin@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle relative paths in permalinks
Ticket Link
https://mattermost.atlassian.net/browse/MM-51245