Skip to content

[GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. - #683

Merged
hanzei merged 5 commits into
mattermost:masterfrom
Brightscout:MM-418
Nov 24, 2023
Merged

[GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'.#683
hanzei merged 5 commits into
mattermost:masterfrom
Brightscout:MM-418

Conversation

@Kshitij-Katiyar

@Kshitij-Katiyar Kshitij-Katiyar commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Summary

  • Currently, subscriptions allow adding repositories or an organization to a subscription. Added an additional --exclude flag that will allow excluding repositories from the webhook notification.

  • Issue #418

@Nityanand13 @Kshitij-Katiyar
[MI-2874]: Added --exclude option to subscriptions command (#24)
f744885 
* [MI-2874]: Added --exclude option to subscriptions commandx

* [MI-2874]:Updated the read me files

* [MI-2874]:Fixed review comments

* [MI-2874]:Fixed review comments

---------

Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>
@Kshitij-Katiyar
Kshitij-Katiyar requested a review from hanzei as a code owner June 12, 2023 12:10
@Kshitij-Katiyar Kshitij-Katiyar changed the title [GH418-]: Fixed issue #418 'Added --exclude option to subscriptions command'. [GH418]: Fixed issue #418 'Added --exclude option to subscriptions command'. Jun 12, 2023
@mattermost-build

mattermost-build commented Jun 12, 2023

Copy link
Copy Markdown
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter

codecov-commenter commented Jun 12, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (dcf1828) 15.63% compared to head (c1ce0fe) 15.57%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   15.63%   15.57%   -0.07%     
==========================================
  Files          15       15              
  Lines        5518     5541      +23     
==========================================
  Hits          863      863              
- Misses       4613     4636      +23     
  Partials       42       42
Impacted Files Coverage Δ
server/plugin/command.go 8.03% <0.00%> (-0.07%) ⬇️
server/plugin/subscriptions.go 8.23% <0.00%> (-0.66%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Kshitij-Katiyar Kshitij-Katiyar changed the title [GH418]: Fixed issue #418 'Added --exclude option to subscriptions command'. [GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. Jun 12, 2023
hanzei
hanzei approved these changes Jun 20, 2023
View reviewed changes

@hanzei hanzei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Comment thread server/plugin/subscriptions.go Outdated
Comment thread server/plugin/subscriptions.go Outdated
Comment thread server/plugin/command.go Outdated
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 20, 2023
@hanzei
hanzei requested a review from crspeller June 20, 2023 17:29
@hanzei

hanzei commented Jun 20, 2023

Copy link
Copy Markdown
Contributor

@Kshitij-Katiyar Merging master might fix CI

@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Jun 21, 2023
Merged
@crspeller crspeller removed the 2: Dev Review Requires review by a core committer label Jun 27, 2023
@crspeller
crspeller requested a review from DHaussermann June 27, 2023 19:54
@mattermost-build

mattermost-build commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@hanzei hanzei linked an issue Sep 29, 2023 that may be closed by this pull request
Add --exclude option to subscriptions command #418
Closed
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.3.0 milestone Oct 5, 2023
@hanzei
hanzei removed the request for review from DHaussermann October 16, 2023 20:44
@hanzei hanzei mentioned this pull request Nov 9, 2023
Merged
@avas27JTG avas27JTG modified the milestones: v2.3.0, v2.2.0 Nov 13, 2023
AayushChaudhary0001
AayushChaudhary0001 approved these changes Nov 24, 2023
View reviewed changes

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested "--exclude" flag in subscriptions and it's working fine, LGTM.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Nov 24, 2023
@hanzei
hanzei merged commit 573e4a3 into mattermost:master Nov 24, 2023
This was referenced Dec 22, 2023
Closed
Merged
@raghavaggarwal2308 raghavaggarwal2308 mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crspeller crspeller crspeller approved these changes
@hanzei hanzei hanzei approved these changes
+1 more reviewer
@AayushChaudhary0001 AayushChaudhary0001 AayushChaudhary0001 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

4: Reviews Complete All reviewers have approved the pull request Contributor

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

Add --exclude option to subscriptions command

8 participants

@Kshitij-Katiyar @mattermost-build @codecov-commenter @hanzei @crspeller @AayushChaudhary0001 @avas27JTG @Nityanand13