Skip to content

Update flows.go - #690

Merged
cwarnermm merged 1 commit into
mattermost:masterfrom
ShrootBuck:ShrootBuck-patch-1
Aug 16, 2023
Merged

cwarnermm merged 1 commit into
mattermost:masterfrom
ShrootBuck:ShrootBuck-patch-1

Conversation

@ShrootBuck

Copy link
Copy Markdown
Contributor

Most people are prompted for GitHub Mobile or an authenticator app. Generalizing the language a bit just makes it a teeny tiny bit more concise.

@ShrootBuck
ShrootBuck requested a review from hanzei as a code owner August 16, 2023 00:16
@mattermost-build

Copy link
Copy Markdown
Contributor

Hello @ShrootBuck,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@hanzei
hanzei requested a review from cwarnermm August 16, 2023 10:39
@hanzei hanzei added the 1: PM Review Requires review by a product manager label Aug 16, 2023
@hanzei

hanzei commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @ShrootBuck 👍

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (11815f8) 15.51% compared to head (19fa2b7) 15.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   15.51%   15.51%           
=======================================
  Files          15       15           
  Lines        5543     5543           
=======================================
  Hits          860      860           
  Misses       4641     4641           
  Partials       42       42           
Files Changed Coverage Δ
server/plugin/flows.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwarnermm cwarnermm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ShrootBuck!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager labels Aug 16, 2023
@cwarnermm
cwarnermm merged commit f8cb86e into mattermost:master Aug 16, 2023
@ShrootBuck
ShrootBuck deleted the ShrootBuck-patch-1 branch August 16, 2023 15:17
@avas27JTG avas27JTG mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request Contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants