[GH-693] Fix improper rendering of some unreads in the response of "/github todo" command - #699
Merged
Merged
Conversation
…/github todo" command (#36)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 15.78% 15.92% +0.13%
==========================================
Files 15 15
Lines 5574 5583 +9
==========================================
+ Hits 880 889 +9
Misses 4652 4652
Partials 42 42
☔ View full report in Codecov by Sentry. |
hanzei
requested changes
Sep 26, 2023
mickmister
approved these changes
Sep 27, 2023
Merged
AayushChaudhary0001
approved these changes
Nov 21, 2023
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
Tested and Approved
All the links are reflected well and redirecting the user correctly to the desired page, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The URL that was used to create the pretext of the unread message and the repo URL was missing in the body of Discussion and CheckSuite type unread. We updated the code to use the repo link present in the body of an unread message. Also, we couldn't find any possible way to get the URL of "Discussion" or "CheckSuite", so we are not displaying them as a link.
Screenshots
Earlier:

Now:

Possible risk:
What to test:
/github todocommand are rendered and working properly.Steps to reproduce
/github todocommand in any MM channel.Environment:
MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0
Ticket Link
Fixes #693