[MM-166] Fix issue: decription not visible in tooltip and removed "see more" link - #735
Conversation
| max-height: 150px; | ||
| line-height: 1.25; | ||
| overflow: hidden; |
There was a problem hiding this comment.
What are the reasons/risks for this change?
There was a problem hiding this comment.
@mickmister This was being used to trim the description when it was too long. We modified the logic to set a max length to the description now.
There was a problem hiding this comment.
It's still possible that it overflows though right? Is there any risk in keeping overflow: hidden?
There was a problem hiding this comment.
@mickmister I don't think it will overflow but there is no risk in keeping it so I have reverted the change
There was a problem hiding this comment.
Was it the overflow: hidden that was making it so the description wasn't being shown at all?
There was a problem hiding this comment.
@mickmister No, the component ReactMarkdown was not used properly.
| <div className='markdown-text mt-1 mb-1'> | ||
| <ReactMarkdown | ||
| source={data.body} | ||
| linkTarget='_blank' |
There was a problem hiding this comment.
What is the risk in removing this linkTarget prop?
There was a problem hiding this comment.
@mickmister I misunderstood the use of this prop. Added it back
mickmister
left a comment
mickmister
left a comment
There was a problem hiding this comment.
Great job @raghavaggarwal2308 👍 Looks good, just a few comments for discussion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 15.78% 15.78%
=======================================
Files 15 15
Lines 5770 5770
=======================================
Hits 911 911
Misses 4817 4817
Partials 42 42 ☔ View full report in Codecov by Sentry. |
| max-height: 150px; | ||
| line-height: 1.25; | ||
| overflow: hidden; |
There was a problem hiding this comment.
It's still possible that it overflows though right? Is there any risk in keeping overflow: hidden?
hanzei
added
3: QA Review
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
This PR has been tested for the following scenarios:-
- Added description in the tooltip.
- Removed the "See more" link from the tooltip.
- Text gets trimmed if its length is too much.
The PR is working fine for the above conditions, LGTM. Approved.
hanzei
added
4: Reviews Complete
5 participants
Summary
Screenshot
What to test
Steps to test:
Ticket Link
Fixes #734