Skip to content

MM-813: Fixed the issue of wrong name shown in subscription when PR is moved from draft to ready for review - #814

Merged
raghavaggarwal2308 merged 1 commit into
masterfrom
MM-813
Oct 11, 2024
Merged

raghavaggarwal2308 merged 1 commit into
masterfrom
MM-813

Conversation

@Kshitij-Katiyar

@Kshitij-Katiyar Kshitij-Katiyar commented Aug 27, 2024 •

Copy link
Copy Markdown
Contributor

Description

Fixed the issue of the wrong name shown in the subscription when PR is moved from draft to ready for review

Ticket link

Fixes #813

What to test

  • Create a subscription for a repo
  • Create a PR with user B and mark it as draft
  • Mark the PR as ready for review from user A

Now

#new-pull-request by B

Before

#new-pull-request by A

@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Aug 27, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Aug 28, 2024
@AayushChaudhary0001

Copy link
Copy Markdown

@Kshitij-Katiyar I was testing this PR and this functionality is not working, can you please take a look at it as discussed?
Adding screenshots for reference:-
image

@Kshitij-Katiyar

Kshitij-Katiyar commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor Author

@Kshitij-Katiyar I was testing this PR and this functionality is not working, can you please take a look at it as discussed? Adding screenshots for reference:- image

@AayushChaudhary0001 I think the PR is working as expected, this PR aims to fix the issue that when a user moves a PR from draft to ready for review, his name is shown in the subscription message that he created a new PR regardless of the author of the PR.
With the changes of this PR, no matter who moves the PR from draft to ready to review, it will show the author of the PR in the subscription message.

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested according to the above clarification, and it is working fine. The user receives notification of the user who created the PR despite who moved it to another state, LGTM. Approved.

@raghavaggarwal2308
raghavaggarwal2308 merged commit 267c219 into master Oct 11, 2024
@raghavaggarwal2308
raghavaggarwal2308 deleted the MM-813 branch October 11, 2024 08:38
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.4.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: QA Review Requires review by a QA tester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Showing invalid name when a draft PR is marked as ready

4 participants