[MM-874]: Fixed the issue of LHS not working without setting organisation lock

[Kshitij-Katiyar]

Summary

Fixed the issue of Github LHS not working if any organization is not set in the organization lock of the plugin config

What to test

• Check the data of LHS with and without organisation lock

[AayushChaudhary0001]

@Kshitij-Katiyar I was testing this PR and faced a new issue.
While testing this PR without adding any organization, the data was not getting populated in the LHS and no error was received. On further investigation, I found that I need to grant the access of the orgs to my Github's personal access token. I have added the error below as per the server logs. Can we try to provide such error as a direct message from the Github DM bot..

{"timestamp":"2024-10-23 15:26:11.959 +05:30","level":"warn","msg":"Failed to search for the sidebar data","caller":"app/plugin_api.go:1006","plugin_id":"github","userid":"db84puwc6tn3frubpu1xfim3to","github username":"AayushChaudhary0001","error":"Not able to excute the query: error in executing query: Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization."}

[Kshitij-Katiyar]

@Kshitij-Katiyar I was testing this PR and faced a new issue. While testing this PR without adding any organization, the data was not getting populated in the LHS and no error was received. On further investigation, I found that I need to grant the access of the orgs to my Github's personal access token. I have added the error below as per the server logs. Can we try to provide such error as a direct message from the Github DM bot..

{"timestamp":"2024-10-23 15:26:11.959 +05:30","level":"warn","msg":"Failed to search for the sidebar data","caller":"app/plugin_api.go:1006","plugin_id":"github","userid":"db84puwc6tn3frubpu1xfim3to","github username":"AayushChaudhary0001","error":"Not able to excute the query: error in executing query: Resource protected by organization SAML enforcement. You must grant your OAuth token access to this organization."}

@AayushChaudhary0001 This error can only occur in case the User has PRs in an org that has not been granted access to the OAuth app. It is expected that LHS will show data from the organizations granted access to the Oauth app.
This error log will not cause any issues with the plugin functionality.

[arush-vashishtha]

@Kshitij-Katiyar, When the user is part of an external organization and the organization also have granted access to the Oauth application as we can see in the below screenshot. The very first organization has granted access,

But the count in the LHS is not counting the events related to that external organization and also when the user opens the list of event it is not showing those events.

[Kshitij-Katiyar]

@arush-vashishtha You can enable the below configuration related to private repo and hopefully get to see the PRs you want

[arush-vashishtha]

@arush-vashishtha You can enable the below configuration related to private repo and hopefully get to see the PRs you want

Thank you, it is working now.

[arush-vashishtha]

This PR has been tested and the desired functionality LGTM. The user is getting the count for all the organizations in the LHS when the organization lock is not set. For external organizations, the user must enable the settings discussed above.

[arush-vashishtha]

Tested and verified, the functionality is looking good to me.